https://bugzilla.redhat.com/show_bug.cgi?id=1912528
Michel Alexandre Salim <michel(a)michel-slm.name> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #2 from Michel Alexandre Salim <michel(a)michel-slm.name> ---
Looks fine!
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Unknown or generated", "*No
copyright* Apache License 2.0", "Apache License 2.0". 33 files have
unknown license. Detailed output of licensecheck in
/home/michel/src/fedora/reviews/1912528-golang-github-
facebookincubator-nvdtools/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/gocode/src/github.com(golang-github-hashicorp-multierror-
devel, golang-github-nicksnyder-i18n-devel, golang-github-bouk-
[..snip..]
this is likely /usr/share/gocode/src/github.com in the devel package,
but it's automatically generated by the Golang packaging macros and all
similar devel packages break this anyway. Not a problem with this package
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 92160 bytes in 18 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in nvdtools
, golang-github-facebookincubator-nvdtools-devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: nvdtools-0.1.4-1.fc34.x86_64.rpm
golang-github-facebookincubator-nvdtools-devel-0.1.4-1.fc34.noarch.rpm
golang-github-facebookincubator-nvdtools-0.1.4-1.fc34.src.rpm
nvdtools.x86_64: E: shared-lib-without-dependency-information
/usr/bin/b64schema
nvdtools.x86_64: E: shared-lib-without-dependency-information /usr/bin/cpe2cve
nvdtools.x86_64: E: shared-lib-without-dependency-information /usr/bin/csv2cpe
nvdtools.x86_64: E: shared-lib-without-dependency-information
/usr/bin/redhat_filter
nvdtools.x86_64: E: shared-lib-without-dependency-information /usr/bin/rpm2cpe
nvdtools.x86_64: E: shared-lib-without-dependency-information
/usr/bin/rustsec2nvd
nvdtools.x86_64: E: shared-lib-without-dependency-information
/usr/bin/vfeed2nvd
nvdtools.x86_64: E: shared-lib-without-dependency-information
/usr/bin/wfnconvert
nvdtools.x86_64: W: no-manual-page-for-binary b64schema
nvdtools.x86_64: W: no-manual-page-for-binary cpe2cve
nvdtools.x86_64: W: no-manual-page-for-binary csv2cpe
nvdtools.x86_64: W: no-manual-page-for-binary fireeye2nvd
nvdtools.x86_64: W: no-manual-page-for-binary flexera2nvd
nvdtools.x86_64: W: no-manual-page-for-binary idefense2nvd
nvdtools.x86_64: W: no-manual-page-for-binary nvdsync
nvdtools.x86_64: W: no-manual-page-for-binary rbs2nvd
nvdtools.x86_64: W: no-manual-page-for-binary redhat2nvd
nvdtools.x86_64: W: no-manual-page-for-binary redhat_filter
nvdtools.x86_64: W: no-manual-page-for-binary redhat_query
nvdtools.x86_64: W: no-manual-page-for-binary rpm2cpe
nvdtools.x86_64: W: no-manual-page-for-binary rustsec2nvd
nvdtools.x86_64: W: no-manual-page-for-binary snyk2nvd
nvdtools.x86_64: W: no-manual-page-for-binary vfeed2nvd
nvdtools.x86_64: W: no-manual-page-for-binary vulndb
nvdtools.x86_64: W: no-manual-page-for-binary wfnconvert
golang-github-facebookincubator-nvdtools-devel.noarch: W: hidden-file-or-dir
/usr/share/gocode/src/github.com/facebookincubator/nvdtools/.goipath
3 packages and 0 specfiles checked; 8 errors, 18 warnings.
Rpmlint (installed packages)
----------------------------
golang-github-facebookincubator-nvdtools-devel.noarch: W: hidden-file-or-dir
/usr/share/gocode/src/github.com/facebookincubator/nvdtools/.goipath
nvdtools.x86_64: E: shared-lib-without-dependency-information
/usr/bin/b64schema
nvdtools.x86_64: E: shared-lib-without-dependency-information /usr/bin/cpe2cve
nvdtools.x86_64: E: shared-lib-without-dependency-information /usr/bin/csv2cpe
nvdtools.x86_64: E: shared-lib-without-dependency-information
/usr/bin/redhat_filter
nvdtools.x86_64: E: shared-lib-without-dependency-information /usr/bin/rpm2cpe
nvdtools.x86_64: E: shared-lib-without-dependency-information
/usr/bin/rustsec2nvd
nvdtools.x86_64: E: shared-lib-without-dependency-information
/usr/bin/vfeed2nvd
nvdtools.x86_64: E: shared-lib-without-dependency-information
/usr/bin/wfnconvert
nvdtools.x86_64: W: no-manual-page-for-binary b64schema
nvdtools.x86_64: W: no-manual-page-for-binary cpe2cve
nvdtools.x86_64: W: no-manual-page-for-binary csv2cpe
nvdtools.x86_64: W: no-manual-page-for-binary fireeye2nvd
nvdtools.x86_64: W: no-manual-page-for-binary flexera2nvd
nvdtools.x86_64: W: no-manual-page-for-binary idefense2nvd
nvdtools.x86_64: W: no-manual-page-for-binary nvdsync
nvdtools.x86_64: W: no-manual-page-for-binary rbs2nvd
nvdtools.x86_64: W: no-manual-page-for-binary redhat2nvd
nvdtools.x86_64: W: no-manual-page-for-binary redhat_filter
nvdtools.x86_64: W: no-manual-page-for-binary redhat_query
nvdtools.x86_64: W: no-manual-page-for-binary rpm2cpe
nvdtools.x86_64: W: no-manual-page-for-binary rustsec2nvd
nvdtools.x86_64: W: no-manual-page-for-binary snyk2nvd
nvdtools.x86_64: W: no-manual-page-for-binary vfeed2nvd
nvdtools.x86_64: W: no-manual-page-for-binary vulndb
nvdtools.x86_64: W: no-manual-page-for-binary wfnconvert
2 packages and 0 specfiles checked; 8 errors, 18 warnings.
Source checksums
----------------
https://github.com/facebookincubator/nvdtools/archive/v0.1.4/nvdtools-0.1...
:
CHECKSUM(SHA256) this package :
b3ca65cb447a76b62988e77782be81e451ae5e7dfdfa630d9a1cbff1857905a8
CHECKSUM(SHA256) upstream package :
b3ca65cb447a76b62988e77782be81e451ae5e7dfdfa630d9a1cbff1857905a8
Requires
--------
nvdtools (rpmlib, GLIBC filtered):
libc.so.6()(64bit)
libpthread.so.0()(64bit)
golang-github-facebookincubator-nvdtools-devel (rpmlib, GLIBC filtered):
go-filesystem
golang(github.com/BurntSushi/toml)
golang(github.com/dgrijalva/jwt-go)
golang(github.com/facebookincubator/flog)
golang(github.com/go-sql-driver/mysql)
golang(github.com/pkg/errors)
golang(github.com/spf13/cobra)
golang(github.com/spf13/pflag)
golang(golang.org/x/oauth2)
golang(golang.org/x/oauth2/clientcredentials)
golang(golang.org/x/sync/errgroup)
Provides
--------
nvdtools:
nvdtools
nvdtools(x86-64)
golang-github-facebookincubator-nvdtools-devel:
golang(github.com/facebookincubator/nvdtools/cpedict)
golang(github.com/facebookincubator/nvdtools/cvefeed)
golang(github.com/facebookincubator/nvdtools/cvefeed/nvd)
golang(github.com/facebookincubator/nvdtools/cvefeed/nvd/schema)
golang(github.com/facebookincubator/nvdtools/cvss2)
golang(github.com/facebookincubator/nvdtools/cvss3)
golang(github.com/facebookincubator/nvdtools/providers/fireeye/api)
golang(github.com/facebookincubator/nvdtools/providers/fireeye/schema)
golang(github.com/facebookincubator/nvdtools/providers/flexera/api)
golang(github.com/facebookincubator/nvdtools/providers/flexera/schema)
golang(github.com/facebookincubator/nvdtools/providers/idefense/api)
golang(github.com/facebookincubator/nvdtools/providers/idefense/schema)
golang(github.com/facebookincubator/nvdtools/providers/lib/client)
golang(github.com/facebookincubator/nvdtools/providers/lib/rate)
golang(github.com/facebookincubator/nvdtools/providers/lib/runner)
golang(github.com/facebookincubator/nvdtools/providers/nvd)
golang(github.com/facebookincubator/nvdtools/providers/rbs/api)
golang(github.com/facebookincubator/nvdtools/providers/rbs/schema)
golang(github.com/facebookincubator/nvdtools/providers/redhat)
golang(github.com/facebookincubator/nvdtools/providers/redhat/api)
golang(github.com/facebookincubator/nvdtools/providers/redhat/check)
golang(github.com/facebookincubator/nvdtools/providers/redhat/schema)
golang(github.com/facebookincubator/nvdtools/providers/rustsec)
golang(github.com/facebookincubator/nvdtools/providers/snyk/api)
golang(github.com/facebookincubator/nvdtools/providers/snyk/schema)
golang(github.com/facebookincubator/nvdtools/providers/vfeed/api)
golang(github.com/facebookincubator/nvdtools/providers/vfeed/schema)
golang(github.com/facebookincubator/nvdtools/rpm)
golang(github.com/facebookincubator/nvdtools/stats)
golang(github.com/facebookincubator/nvdtools/vulndb)
golang(github.com/facebookincubator/nvdtools/vulndb/debug)
golang(github.com/facebookincubator/nvdtools/vulndb/mysql)
golang(github.com/facebookincubator/nvdtools/vulndb/sqlutil)
golang(github.com/facebookincubator/nvdtools/wfn)
golang-github-facebookincubator-nvdtools-devel
golang-ipath(github.com/facebookincubator/nvdtools)
Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 1912528
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: R, Ocaml, Python, Java, Perl, SugarActivity, C/C++, PHP,
Haskell, fonts
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component