[Bug 1546544] Re-Review Request: renaming package bear to
bear-factory
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1546544
--- Comment #7 from Till Hofmann <thofmann(a)fedoraproject.org> ---
Issues:
> %package bear-engine
should be
> %package -n bear-engine
and
> Requires: %{name}-engine%{?_isa} = %{version}-%{release}
should be
> Requires: bear-engine%{?_isa} = %{version}-%{release}
because %name is bear-factory.
If you want to keep using a macro, you could do instead:
> %global srcname bear
and then use
> %package -n %{srcname}-engine
and
> Requires: %{srcname}-engine%{?_isa} = %{version}-%{release}
Whatever you prefer.
The packages are currently not installable due to the wrong sub-package naming.
I'll continue the review when this is fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5 years, 7 months
[Bug 1546544] Re-Review Request: renaming package bear to
bear-factory
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1546544
--- Comment #5 from MartinKG <mgansser(a)online.de> ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/bear-factory.spec
%changelog
* Fri Oct 12 2018 Martin Gansser <martinkg(a)fedoraproject.org> -
0.7.0-0.21.20180825git2a78522
- Remove scriptlets
- Add -Wl,--as-needed" to avoid "unused-direct-shlib-dependency" warnings
- Remove subpackage engine to bear-engine
I have only uploaded the rpm SPEC file due compilation issues:
[ 12%] Building CXX object
bear-factory/bear-editor/src/bf/CMakeFiles/bear-editor.dir/code/accelerator_table.cpp.o
cd
/home/martin/rpmbuild/BUILD/bear-2a785228d85997dc1682ee71899841528fa09c33/bear-factory/bear-editor/src/bf
&& /usr/bin/c++ -DBEAR_FACTORY_TEXT_DOMAIN_PATH=/usr/share/locale -DWXUSINGDLL
-D_FILE_OFFSET_BITS=64 -D__WXGTK__ -Dbear_editor_EXPORTS
-I/home/martin/rpmbuild/BUILD/bear-2a785228d85997dc1682ee71899841528fa09c33/bear-engine/common/include
-I/home/martin/rpmbuild/BUILD/bear-2a785228d85997dc1682ee71899841528fa09c33/bear-factory/bear-editor/src/bf/..
-isystem /usr/lib64/wx/include/gtk3-unicode-3.0 -isystem /usr/include/wx-3.0
-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
-Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong
-grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic
-fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -pthread
-fPIC -Wall -std=c++11 -pedantic -Wmissing-field-initializers -Wuninitialized
'-DBF_IMAGES_PATH="/usr/share/bear-factory/images"' -o
CMakeFiles/bear-editor.dir/code/accelerator_table.cpp.o -c
/home/martin/rpmbuild/BUILD/bear-2a785228d85997dc1682ee71899841528fa09c33/bear-factory/bear-editor/src/bf/code/accelerator_table.cpp
/home/martin/rpmbuild/BUILD/bear-2a785228d85997dc1682ee71899841528fa09c33/bear-factory/bear-editor/src/bf/code/accelerator_table.cpp:
In member function 'void bf::accelerator_table::on_key_pressed(wxKeyEvent&)':
/home/martin/rpmbuild/BUILD/bear-2a785228d85997dc1682ee71899841528fa09c33/bear-factory/bear-editor/src/bf/code/accelerator_table.cpp:102:45:
error: 'virtual bool wxEvtHandler::ProcessEvent(wxEvent&)' is inaccessible
within this context
m_event_handler.ProcessEvent( command );
^
In file included from /usr/include/wx-3.0/wx/window.h:18,
from
/home/martin/rpmbuild/BUILD/bear-2a785228d85997dc1682ee71899841528fa09c33/bear-factory/bear-editor/src/bf/../bf/accelerator_table.hpp:19,
from
/home/martin/rpmbuild/BUILD/bear-2a785228d85997dc1682ee71899841528fa09c33/bear-factory/bear-editor/src/bf/code/accelerator_table.cpp:14:
/usr/include/wx-3.0/wx/event.h:3355:18: note: declared here
virtual bool ProcessEvent(wxEvent& event);
^~~~~~~~~~~~
make[2]: ***
[bear-factory/bear-editor/src/bf/CMakeFiles/bear-editor.dir/build.make:66:
bear-factory/bear-editor/src/bf/CMakeFiles/bear-editor.dir/code/accelerator_table.cpp.o]
Error 1
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5 years, 7 months