https://bugzilla.redhat.com/show_bug.cgi?id=1430476
Bug ID: 1430476
Summary: Review Request: python-xmlrunner - unittest-based test
runner with Ant/JUnit like XML reporting
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: orion(a)cora.nwra.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL: https://www.cora.nwra.com/~orion/fedora/python-xmlrunner.spec
SRPM URL:
https://www.cora.nwra.com/~orion/fedora/python-xmlrunner-1.7.7-1.fc27.src.r…
Description:
xmlrunner is a unittest test runner that can save test results to XML files
that can be consumed by a wide range of tools, such as build systems, IDEs
and continuous integration servers.
Fedora Account System Username: orion
https://koji.fedoraproject.org/koji/taskinfo?taskID=18266859
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1526091
--- Comment #6 from Lin Yang <lin.a.yang(a)intel.com> ---
Sure, I will check it and keep you update.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1036130
Robert-André Mauchin <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|nobody(a)fedoraproject.org |zebob.m(a)gmail.com
Flags| |fedora-review?
--- Comment #36 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
- Add a comment for each patch explaining what they do
- Group: is not needed in Fedora. See:
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
- Use a more meaningful name for your archive, with the following Source0:
Source0:
https://github.com/%{sname}/%{sname}/archive/v%{version}/%{name}-%{version}…
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "PostgreSQL", "Unknown or generated". 62 files have unknown
license. Detailed output of licensecheck in
/home/bob/packaging/review/plv8/review-plv8/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/pgsql/extension(orafce, postgresql-server)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
plv8-debuginfo , plv8-debugsource
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[-]: Spec use %global instead of %define unless justified.
Note: %define requiring justification: %define _configure :
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: plv8-2.1.0-3.fc28.x86_64.rpm
plv8-debuginfo-2.1.0-3.fc28.x86_64.rpm
plv8-debugsource-2.1.0-3.fc28.x86_64.rpm
plv8-2.1.0-3.fc28.src.rpm
plv8-debugsource.x86_64: W: no-documentation
plv8.src: W: strange-permission plv8-2.1.0-make-test.patch 600
plv8.src: W: strange-permission plv8-2.1.0-make.patch 600
4 packages and 0 specfiles checked; 0 errors, 3 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1526091
--- Comment #4 from Lin Yang <lin.a.yang(a)intel.com> ---
Nate and I have finished these above steps. Does the content in
https://github.com/ntpttr/sushy-fedora look good?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1268698
Bug ID: 1268698
Summary: Review Request: rubygem-guard-bundler - Guard gem for
Bundler
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: ilya.gradina(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-guard…
SRPM URL:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-guard…
Description: Guard::Bundler automatically install/update your gem bundle when
needed.
Fedora Account System Username: ilgrad
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component