[Bug 1079499] New: Review Request: sockperf - network benchmarking utility for testing latency and throughput
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1079499
Bug ID: 1079499
Summary: Review Request: sockperf - network benchmarking
utility for testing latency and throughput
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: mschmidt(a)redhat.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL: http://michich.fedorapeople.org/sockperf/sockperf.spec
SRPM URL:
http://michich.fedorapeople.org/sockperf/sockperf-2.5.241-1.fc21.src.rpm
Description:
sockperf is a network benchmarking utility over socket API that was designed
for testing performance (latency and throughput) of high-performance systems
(it is also good for testing performance of regular networking systems as
well). It covers most of the socket API calls and options.
Specifically, in addition to the standard throughput tests, sockperf, does the
following:
* Measure latency of each discrete packet at sub-nanosecond resolution (using
TSC register that counts CPU ticks with very low overhead).
* Does the above for both ping-pong mode and for latency under load mode. This
means that we measure latency of single packets even under load of millions
Packets Per Second (without waiting for reply of packet before sending
subsequent packet on time)
* Enable spike analysis by providing histogram, with various percentiles of the
packets’ latencies (for example: median, min, max, 99% percentile, and more),
(this is in addition to average and standard deviation). Also, sockperf
provides full log with all packet’s tx/rx times that can be further analyzed
with external tools, such as MS-Excel or matplotlib - All this without
affecting the benchmark itself.
* Support MANY optional settings for good coverage of socket API and network
configurations, while still keeping very low overhead in the fast path to
allow cleanest results.
Fedora Account System Username: michich
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10 years
[Bug 1090933] Review Request : fusioninventory-agent
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1090933
--- Comment #3 from Michael Schwendt <bugs.michael(a)gmx.net> ---
Compared with the last official build in koji,
http://koji.fedoraproject.org/koji/packageinfo?packageID=12285
you've introduced several packaging mistakes related to "unowned directories"
and duplicated files:
https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ow...
https://fedoraproject.org/wiki/Packaging:UnownedDirectories
The subpackage inter-dependencies are not trivial, so let's see:
%files -n perl-FusionInventory-Agent
%doc Changes LICENSE THANKS
%{_datadir}/fusioninventory
The last line in this %files list includes the directory
/usr/share/fusioninventory *and* everything in it. That means it includes also
the files and subdirs specified in the subpackages -task-esx, -task-network,
-task-deploy and -task-inventory. Example:
%files task-esx
%{_bindir}/fusioninventory-esx
%{_mandir}/man1/fusioninventory-esx.1*
%{_datadir}/fusioninventory/lib/FusionInventory/Agent/Task/ESX.pm
%{_datadir}/fusioninventory/lib/FusionInventory/Agent/SOAP
One way to avoid that is to either %exclude all those files (included in the
subpackages already) in the perl-FusionInventory-Agent package. Or be more
specific about what to include in the perl-FusionInventory-Agent package based
on including only the %dir
%files -n perl-FusionInventory-Agent
%doc Changes LICENSE THANKS
%dir %{_datadir}/fusioninventory
...add specific files and needed %dir entries here...
Note that there are a various subdirs in paths such as
%{_datadir}/fusioninventory/lib/FusionInventory/Agent/Task/, which must not be
"unowned".
A related hint: To increase readability of directory entries in %files lists,
many packagers append a trailing slash to emphasize that the entry is for a
directory tree and not a single file:
%{_datadir}/somedirectory/
[...]
Your %changelog refers to 2.3.6-1 but the spec file is 2.3.6-0:
Version: 2.3.6
Release: 0%{?dist}
Consider pointing the fedora-review tool at this ticket (run "fedora-review -b
1090933") to let it perform many tests not limited to running rpmlint on all
packages.
> find %{buildroot} -type d -depth -exec rmdir {} 2>/dev/null ';'
Not needed anymore for many years.
> %files
> /%{_bindir}/fusioninventory-injector
Why the leading slash?
$ rpm -E %_bindir
/usr/bin
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10 years