https://bugzilla.redhat.com/show_bug.cgi?id=1098330
Lubomir Rintel <lkundrak(a)v3.sk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #3 from Lubomir Rintel <lkundrak(a)v3.sk> ---
* Package named correctly
* Packaging the latest version
* License tag correct
* License is fine for fedora
* Builds fine in mock
* Rpmlint is happy
* SPEC file is clean and legible
* Filelist sane
* Requires sane
* Provides sane
APPROVED
One minor suggestion; these are no longer required in a modern RPM:
0.) Cleaning buildroot before install
rm -rf $RPM_BUILD_ROOT
1.) %clean section altogether
%clean
rm -rf $RPM_BUILD_ROOT
2.) %defattr
%defattr(-,root,root,-)
3.) BuildRoot tag
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component