[Bug 718395] Review Request: libmusicbrainz4-4.0.0 - Library for accessing MusicBrainz servers
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=718395
Cosimo Cecchi <ccecchi(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ccecchi(a)redhat.com
--- Comment #6 from Cosimo Cecchi <ccecchi(a)redhat.com> 2012-03-06 10:55:37 EST ---
Okay, giving a shot at this - it's my first package review, so apologies if I
am missing something.
- Package meets naming and packaging guidelines - OK
- Spec file matches base package name. - OK
- Spec has consistent macro usage. - OK
- Meets Packaging Guidelines. - OK
- License - LGPLv2+ (OK)
- License field in spec matches - OK
- License file included in package - OK
- Spec in American English - OK
- Spec is legible. - OK
- Sources match upstream md5sum: - OK
21c33f5dd20b8bb945b800e2a964f27e libmusicbrainz-4.0.0.tar.gz
- Package needs ExcludeArch - N/A
- BuildRequires correct - OK
- Spec handles locales/find_lang - N/A
- Package is code or permissible content. - OK
- Doc subpackage needed/used. - N/A
- Packages %doc files don't affect runtime. - OK
- Headers/static libs in -devel subpackage. - OK
- Spec has needed ldconfig in post and postun - OK
- .pc files in -devel subpackage/requires pkgconfig - ***
-devel subpackage is missing a requires on pkgconfig
- .so files in -devel subpackage. - OK
- -devel package Requires: %{name} = %{version}-%{release} -OK
- .la files are removed. - ***
They don't seem to be removed, but maybe it's not necessary here?
- Package is a GUI app and has a .desktop file - N/A
- Package compiles and builds on at least one arch. - tested x86_64 w/mock
- Package has no duplicate files in %files. - OK
- Package doesn't own any directories other packages own. -OK
- Package owns all the directories it creates. - OK
- No rpmlint output. - ***
libmusicbrainz4.src: W: spelling-error %description -l en_US metadata -> meta
data, meta-data, metatarsal
libmusicbrainz4.src: W: spelling-error %description -l en_US lookup -> lockup,
hookup, look up
libmusicbrainz4.src: W: spelling-error %description -l en_US roms -> toms,
rims, oms
- final provides and requires are sane: OK
SHOULD Items:
- Should build in mock. - tested x86_64
- Should build on all supported archs - didn't test
- Should function as described. - didn't test
- Should have sane scriptlets. - OK
- Should have subpackages require base package with fully versioned depend. -
OK
- Should have dist tag - OK
- Should package latest version - OK
Issues:
- Add pkgconfig to Requires in -devel
- Check whether it's required to remove .la files
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
11 years, 3 months
[Bug 675478] New: Review Request: gprbuild - Ada project builder
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: gprbuild - Ada project builder
https://bugzilla.redhat.com/show_bug.cgi?id=675478
Summary: Review Request: gprbuild - Ada project builder
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: pavel(a)zhukoff.net
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com, fedora-package-review(a)redhat.com
Estimated Hours: 0.0
Classification: Fedora
Spec URL:
http://landgraf.fedorapeople.org/packages/requested/gprbuild/gprbuild.spec
SRPM URL:
http://landgraf.fedorapeople.org/packages/requested/gprbuild/gprbuild-201...
Description:
GPRbuild is an advanced software tool designed to help automate the
construction of multi-language systems. It removes complexity from
multi-language development by allowing developers to quickly and easily compile
and link software written in a combination of languages including Ada,
Assembler, C, C++, and Fortran. Easily extendable by users to cover new
toolchains and languages it is primarily aimed at projects of all sizes
organized into subsystems and libraries and is particularly well-suited for
compiled languages.
koji: Unavailable (see depend tag)
mock: ok
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
11 years, 3 months
[Bug 652034] New: Review Request: python-apipkg - Python namespace control and lazy-import mechanism
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: python-apipkg - Python namespace control and lazy-import mechanism
https://bugzilla.redhat.com/show_bug.cgi?id=652034
Summary: Review Request: python-apipkg - Python namespace
control and lazy-import mechanism
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: fabian(a)bernewireless.net
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com, fedora-package-review(a)redhat.com
Estimated Hours: 0.0
Classification: Fedora
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-apipkg.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/python-apipkg-1.0-1.fc14.src.rpm
Project URL: http://pypi.python.org/pypi/apipkg
Description:
With apipkg you can control the exported namespace of a python package and
greatly reduce the number of imports for your users. It is a small python
module that works on virtually all Python versions, including CPython2.3 to
Python3.1, Jython and PyPy. It co-operates well with Python's help() system,
custom importers (PEP302) and common command line completion tools.
Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2593863
rpmlint output:
[fab@localhost SRPMS]$ rpmlint python-apipkg-1.0-1.fc14.src.rpm
python-apipkg.src: W: spelling-error Summary(en_US) namespace -> name space,
name-space, names pace
python-apipkg.src: W: spelling-error %description -l en_US namespace -> name
space, name-space, names pace
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
[fab@localhost noarch]$ rpmlint python-apipkg-1.0-1.fc14.noarch.rpm
python-apipkg.noarch: W: spelling-error Summary(en_US) namespace -> name space,
name-space, names pace
python-apipkg.noarch: W: spelling-error %description -l en_US namespace -> name
space, name-space, names pace
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
11 years, 3 months
[Bug 735225] New: Review Request: axis2c - Web services engine implemented in C
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: axis2c - Web services engine implemented in C
https://bugzilla.redhat.com/show_bug.cgi?id=735225
Summary: Review Request: axis2c - Web services engine
implemented in C
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: gholms(a)fedoraproject.org
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com,
package-review(a)lists.fedoraproject.org
Classification: Fedora
Story Points: ---
Type: ---
Spec URL: http://gholms.fedorapeople.org/review/axis2c.spec
SRPM URL: http://gholms.fedorapeople.org/review/axis2c-1.6.0-1.src.rpm
Description:
Apache Axis2/C is a Web services engine implemented in the C programming
language. It is based on the extensible and flexible Axis2 architecture.
Apache Axis2/C can be used to provide and consume WebServices. It has
been implemented with portability and ability to embed in mind, hence
could be used as a Web services enabler in other software.
Apache Axis2/C supports SOAP 1.1 and SOAP 1.2, as well as REST style
of Webservices. A single service could be exposed both as a SOAP style
as well as a REST style service simultaneously. It also has built in
MTOM support, that can be used to exchange binary data.
Note to reviewer:
A lot of software that depends on Axis2/C assumes that everything is laid out
in subdirectories of a single installation directory. This doesn't comply with
the FHS, so the %install section installs everything into such a single
directory (%axis2c_home), then moves things into FHS-compliant locations and
adds symlinks to %axis2c_home so dependent software that assumes the single-dir
layout can still build.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
11 years, 3 months
[Bug 648248] New: Review Request: ghc-crypto-api - A generic interface for cryptographic operations
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: ghc-crypto-api - A generic interface for cryptographic operations
https://bugzilla.redhat.com/show_bug.cgi?id=648248
Summary: Review Request: ghc-crypto-api - A generic interface
for cryptographic operations
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: mathstuf(a)gmail.com
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com, fedora-package-review(a)redhat.com
Estimated Hours: 0.0
Classification: Fedora
Spec URL: http://benboeckel.net/packaging/ghc-crypto-api/ghc-crypto-api.spec
SRPM URL:
http://benboeckel.net/packaging/ghc-crypto-api/ghc-crypto-api-0.1.2.4-1.f...
Description:
A generic interface for cryptographic operations, platform
independent quality RNG, property tests and known-answer
tests (KATs) for common algorithms, and a basic benchmark
infrastructure. Maintainers of hash and cipher
implementations are encouraged to add instances for the
classes defined in Crypto.Classes. Crypto users are similarly
encouraged to use the interfaces defined in the Classes
module. Any concepts or functions of general use to more than
one cryptographic algorithm (ex: padding) is within scope of
this package.
% lintmock fedora-14-x86_64-bb
ghc-crypto-api.src: W: strange-permission
ghc-crypto-api-0.1.2.4-data-files.patch 0640L
ghc-crypto-api.src: W: strange-permission ghc-crypto-api.spec 0640L
ghc-crypto-api.src: W: strange-permission crypto-api-0.1.2.4.tar.gz 0640L
ghc-crypto-api-prof.x86_64: E: devel-dependency ghc-crypto-api-devel
ghc-crypto-api-prof.x86_64: W: no-documentation
ghc-crypto-api-prof.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/ghc-6.12.3/crypto-api-0.1.2.4/libHScrypto-api-0.1.2.4_p.a
4 packages and 0 specfiles checked; 1 errors, 5 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
11 years, 3 months