[Bug 554243] Review Request: moovida - Media Center
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=554243
--- Comment #39 from Hans de Goede <hdegoede(a)redhat.com> 2010-08-04 11:19:22 EDT ---
Full review:
Good:
- rpmlint checks return:
moovida.noarch: W: manual-page-warning /usr/share/man/man1/moovida.1.gz 165:
warning: numeric expression expected (got `U')
moovida.noarch: W: no-manual-page-for-binary elisa
moovida-base.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/elisa/core/launcher.py 0644L /usr/bin/python
moovida-base.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/elisa/core/tests/test_launcher.py 0644L
/usr/bin/python
3 packages and 0 specfiles checked; 2 errors, 2 warnings.
You could fix the 1st one by adding a symlink to the manpage for elisa and
you could fix the last 2 by making these files executable (or removing the
shebang), but I consider neither of these 3 to be blockers.
- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv3) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- .desktop file installed for GUI parts
Approved!
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
13 years, 9 months
[Bug 554243] Review Request: moovida - Media Center
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=554243
Hans de Goede <hdegoede(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |hdegoede(a)redhat.com
Blocks|177841(FE-NEEDSPONSOR) |
AssignedTo|nobody(a)fedoraproject.org |hdegoede(a)redhat.com
--- Comment #38 from Hans de Goede <hdegoede(a)redhat.com> 2010-08-04 11:04:22 EDT ---
Hi,
Sorry for the slow response I've been kept very busy by my dayjob and other
things, also I'm going on a short vacation tomorrow, returing Tue Aug 10th, so
my next reply will be a bit slow too.
(In reply to comment #37)
>
> Yep, I think go ahead with getting 1.x into Fedora.
I agree 2.x does not seem to be heading in a direction which results in a
useful home theater / multimedia center UI for Linux in anyway.
As I offered in the -bad and -good plugins reviews I'll review this and when
that is done sponsor you. I hope to finish reviewing atleast the base package
today before my short vacation.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
13 years, 9 months