Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=554243
--- Comment #39 from Hans de Goede <hdegoede(a)redhat.com> 2010-08-04 11:19:22 EDT
---
Full review:
Good:
- rpmlint checks return:
moovida.noarch: W: manual-page-warning /usr/share/man/man1/moovida.1.gz 165:
warning: numeric expression expected (got `U')
moovida.noarch: W: no-manual-page-for-binary elisa
moovida-base.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/elisa/core/launcher.py 0644L /usr/bin/python
moovida-base.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/elisa/core/tests/test_launcher.py 0644L
/usr/bin/python
3 packages and 0 specfiles checked; 2 errors, 2 warnings.
You could fix the 1st one by adding a symlink to the manpage for elisa and
you could fix the last 2 by making these files executable (or removing the
shebang), but I consider neither of these 3 to be blockers.
- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv3) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- .desktop file installed for GUI parts
Approved!
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.