fedora-review denied: [Bug 226660] Merge Review: xterm
by Red Hat Bugzilla
Bug 226660: Merge Review: xterm
Product: Fedora Extras
Version: devel
Component: Package Review
Kevin Fenzi <kevin(a)tummy.com> has denied Kevin Fenzi <kevin(a)tummy.com>'s
request for fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226660
------- Additional Comments from Kevin Fenzi <kevin(a)tummy.com>
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (MIT)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
bf5bb77496ddf95df32b8e752a6cabb0 xterm-223.tgz
bf5bb77496ddf95df32b8e752a6cabb0 xterm-223.tgz.1
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
See below - Package is a GUI app and has a .desktop file
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane:
SHOULD Items:
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag
OK - Should package latest version
2 outstanding bugs, not package related - check for outstanding bugs on
package.
Issues:
1. Would it make sense to make a .desktop file for xterm?
It is a GUI app...
2. rpmlint sez:
rpmlint on ./xterm-debuginfo-223-2.fc7.x86_64.rpm
rpmlint on ./xterm-223-2.fc7.src.rpm
W: xterm summary-not-capitalized xterm terminal emulator for the X Window
System
Might make that a cap X (minor, non blocker)
W: xterm mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 41)
Might pick tabs or spaces and use only one or the other.
rpmlint on ./xterm-223-2.fc7.x86_64.rpm
W: xterm summary-not-capitalized xterm terminal emulator for the X Window
System
E: xterm non-standard-gid /usr/bin/xterm utempter
E: xterm setgid-binary /usr/bin/xterm utempter 02755
E: xterm non-standard-executable-perm /usr/bin/xterm 02755
Ignoreable. This package has to have a sgid utempter binary to
allow it to show login sessions.
Once you have addressed these items (either by making the suggested changes, or
by explaining why they don't make sense), please reassign this review back
to me, and change the 'fedora-review' flag back to ? for me to take action.
17 years, 2 months
fedora-review granted: [Bug 225878] Merge Review: gzip
by Red Hat Bugzilla
Bug 225878: Merge Review: gzip
Product: Fedora Extras
Version: devel
Component: Package Review
Kevin Fenzi <kevin(a)tummy.com> has granted Roozbeh Pournader
<roozbeh(a)farsiweb.info>'s request for fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225878
------- Additional Comments from Kevin Fenzi <kevin(a)tummy.com>
Excellent. Everything looks good from here... this package is APPROVED.
I think the plan is to keep it there open and assigned to you until
it's determined how to import all the approved packages into the new CVS.
Thanks for your prompt response and fixes...
17 years, 2 months
fedora-review granted: [Bug 226003] Merge Review: libexif
by Red Hat Bugzilla
Bug 226003: Merge Review: libexif
Product: Fedora Extras
Version: devel
Component: Package Review
Michael Schwendt <bugs.michael(a)gmx.net> has granted Michael Schwendt
<bugs.michael(a)gmx.net>'s request for fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226003
------- Additional Comments from Michael Schwendt <bugs.michael(a)gmx.net>
APPROVED
(Cannot verify whether %doc files in multi-lib installations can
cause conflicts actually. In case such conflicts are common, perhaps
the packaging committee should discuss that a bit.)
17 years, 2 months
fedora-review granted: [Bug 226478] Merge Review: tar
by Red Hat Bugzilla
Bug 226478: Merge Review: tar
Product: Fedora Extras
Version: devel
Component: Package Review
Michael Schwendt <bugs.michael(a)gmx.net> has granted Michael Schwendt
<bugs.michael(a)gmx.net>'s request for fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226478
------- Additional Comments from Michael Schwendt <bugs.michael(a)gmx.net>
* With the better scriptlet dependencies on /sbin/install-info in
place, "Prereq: info" can be deleted:
$ rpmlint tar-1.15.1-26.src.rpm
W: tar prereq-use info
* Other releases of tar may need "BuildRequires: gettext" for the
message object files. This version doesn't.
* The changes in cvs look fine.
APPROVED
* A side-note about the binary rpm:
$ rpmlint tar-1.15.1-26.i386.rpm
W: tar file-not-utf8 /usr/share/info/tar.info-1.gz
W: tar file-not-utf8 /usr/share/info/tar.info.gz
Indeed, in a single line in both files, Jörg Schilling's name is
encoded in ISO 8859-1. That alone would be easy to fix with "iconv",
and a created patch shows no accidental conversions.
However, there are a few 0x0c carriage-return values in those files
(and also in the texinfo input files), which cause these paragraphs,
where the encoding is wrong, to be hidden when displaying the
documentation with "info". I don't know whether the 0x0c are intentional
or supposed to be 0x0a instead.
17 years, 2 months
fedora-review granted: [Bug 226516] Merge Review: unzip
by Red Hat Bugzilla
Bug 226516: Merge Review: unzip
Product: Fedora Extras
Version: devel
Component: Package Review
Ruben Kerkhof <ruben(a)rubenkerkhof.com> has granted Ivana Varekova
<varekova(a)redhat.com>'s request for fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226516
------- Additional Comments from Ruben Kerkhof <ruben(a)rubenkerkhof.com>
Hi Ivana,
Thanks for fixing all the above-mentioned issues. I don't see any further
blockers, so this package is
approved.
Please leave the ticket assigned to yourself.
Ruben
17 years, 2 months
fedora-review denied: [Bug 226411] Merge Review: setserial
by Red Hat Bugzilla
Bug 226411: Merge Review: setserial
Product: Fedora Extras
Version: devel
Component: Package Review
manuel wolfshant <wolfy(a)nobugconsulting.ro> has denied Tim Waugh
<twaugh(a)redhat.com>'s request for fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226411
------- Additional Comments from manuel wolfshant <wolfy(a)nobugconsulting.ro>
Review for Release: 19.2.2
MUSTFIX:
there are a couple of problems with the spec and the patches
* the fhs patch has two errors
+mandir = @bindir@ <-- this should be @mandir@
+ $(STRIP) $(DESTDIR)$(bindir)/setserial -< should not be at all, leads
to
empty debuginfo
* the readme patch should include references to Fedora, not Red Hat
* the spec does not include the preferred BUILDROOT, does not honor SMP
flags,uses %makeinstall instead of make install
Warning from rpmlint: Summary ends with dot
I will attach the fixes for all of the above. Please use whatever you find
useful and once corrected I will do the formal full review.
17 years, 2 months
fedora-review granted: [Bug 226503] Merge Review: tree
by Red Hat Bugzilla
Bug 226503: Merge Review: tree
Product: Fedora Extras
Version: devel
Component: Package Review
Ruben Kerkhof <ruben(a)rubenkerkhof.com> has granted Tim Waugh
<twaugh(a)redhat.com>'s request for fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226503
------- Additional Comments from Ruben Kerkhof <ruben(a)rubenkerkhof.com>
Thanks Tim, this looks good.
One question though, why do you rm -rf tree in %build? I think rpmbuild does
this by default.
I don't see any blockers, so this package is approved. Please leave the ticket
assigned to yourself.
17 years, 2 months
[Bug 178162] Review Request: libgeotiff
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: libgeotiff
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178162
cbalint(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |cbalint(a)redhat.com
------- Additional Comments From cbalint(a)redhat.com 2007-02-06 14:53 EST -------
The whole thread is about getting grass in fedora extras ?
Indeed i guess the dep tree libgeotiff->gdal->grass.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
17 years, 2 months