fedora-review denied: [Bug 225774] Merge Review: ftp
by Red Hat Bugzilla
Bug 225774: Merge Review: ftp
Product: Fedora Extras
Version: devel
Component: Package Review
Ruben Kerkhof <ruben(a)rubenkerkhof.com> has denied Roozbeh Pournader
<roozbeh(a)farsiweb.info>'s request for fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225774
------- Additional Comments from Ruben Kerkhof <ruben(a)rubenkerkhof.com>
This looks much better!
A few details:
* Remove the commented out BuildRoot, rpmlint complains about it
* Preserve timestamps when installing files (use install -p or cp -p)
17 years, 1 month
fedora-review granted: [Bug 226514] Merge Review: unix2dos
by Red Hat Bugzilla
Bug 226514: Merge Review: unix2dos
Product: Fedora Extras
Version: devel
Component: Package Review
Ruben Kerkhof <ruben(a)rubenkerkhof.com> has granted Tim Waugh
<twaugh(a)redhat.com>'s request for fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226514
------- Additional Comments from Ruben Kerkhof <ruben(a)rubenkerkhof.com>
Ah, Distributable (with a capital D) is a valid license. distributable is not.
DEFAULT_VALID_LICENSES in /usr/share/rpmlint/TagsCheck.py contains a list of
valid licenses.
If you can change that, it would be nice.
Since I see no further blockers, this package is approved. Please leave the
ticket assigned to yourself.
17 years, 1 month
fedora-review denied: [Bug 225797] Merge Review: gimp-data-extras
by Red Hat Bugzilla
Bug 225797: Merge Review: gimp-data-extras
Product: Fedora Extras
Version: devel
Component: Package Review
Roozbeh Pournader <roozbeh(a)farsiweb.info> has denied Roozbeh Pournader
<roozbeh(a)farsiweb.info>'s request for fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225797
------- Additional Comments from Roozbeh Pournader <roozbeh(a)farsiweb.info>
Random first notes:
* Release (1.1.1) should be an integer. You may also add %{?dist} if you wish.
* separate the BuildRequires into two lines. It's not very obvious now.
* change BuildRoot to
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* remove the dot at the end of Summary.
* As /usr/bin is in the execution path, saying /usr/bin/gimptool in the install
section is not necessary. Just use "gimptool", which makes the spec more
legible.
* Use %defattr (-, root, root, -) instead of %defattr (-, root, root)
* The license filed says GPL, while there is nothing in the source tarball that
confirms that. The COPYING file is also empty. (BLOCKER)
* You should ship some of the files as %doc (at least AUTHORS, ChangeLog, NEWS,
and README).
* The spec file is not UTF-8. (BLOCKER)
* The install root is not cleaned at the beginning of %install
17 years, 1 month