fedora-review requested: [Bug 225863] Merge Review: gsl
by Red Hat Bugzilla
Bug 225863: Merge Review: gsl
Product: Fedora Extras
Version: devel
Component: Package Review
José Matos <jamatos(a)fc.up.pt> has asked for fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225863
------- Additional Comments from José Matos <jamatos(a)fc.up.pt>
I have some suggestions regarding the spec file:
- Use the BuildRoot defined in the guidelines (this is suggested but in no way
a blocker)
- for gsl-devel require gsl = %{version}-%{release} it is better to be
safe :-)
- make %{?_smp_mflags} - it works, I have tested it
- in %install it is necessary to clean the buildroot and also %makeinstall
can be replaced with make install DESTDIR=$RPM_BUILD_ROOT, again I have tested
an it works.
- finally the file attributes should be %defattr(-,root,root,-)
There are other issues I would like to search, mainly related with the
static libraries, but before going there I would like to hear you on these
changes.
One final note, a matter of style, I like more the description used in the
spec file distributed in the tar ball, while the one present in the spec file
is, maybe, too terse. Again this is a matter of taste so it is in no way a
blocker.
I will put in the next entry a patch with these changes...
17 years, 3 months
fedora-review denied: [Bug 225822] Merge Review: gnome-media
by Red Hat Bugzilla
Bug 225822: Merge Review: gnome-media
Product: Fedora Extras
Version: devel
Component: Package Review
Deji Akingunola <dakingun(a)gmail.com> has denied Matthias Clasen
<mclasen(a)redhat.com>'s request for fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225822
------- Additional Comments from Deji Akingunola <dakingun(a)gmail.com>
I was looking at the cvs commit mail, and it seems you forgot to actually
commit
the change ;). I'm waiting for anonymous cvs to sync up so I can properly test
it.
17 years, 3 months