fedora-review denied: [Bug 226436] Merge Review: statserial
by Red Hat Bugzilla
Bug 226436: Merge Review: statserial
Product: Fedora Extras
Version: devel
Component: Package Review
manuel wolfshant <wolfy(a)nobugconsulting.ro> has denied manuel wolfshant
<wolfy(a)nobugconsulting.ro>'s request for fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226436
------- Additional Comments from manuel wolfshant <wolfy(a)nobugconsulting.ro>
- there is no URL tag; please provide one if possible
- Package is marked as relocatable; since is a no-no (unless properly
documented
and justified), PREFIX should disappear
- BuildRoot does not have the preferred value
- Release tag should include %{dist}
- %build does not honor $RPM_OPT_FLAGS
- %build should use SMP flags. If it doesn't work, please add a comment
- the dot at the end of Summary should be removed
- the tar.gz includes the GPL v2 license, but the package claims license to be
BSD;
- the license file (COPYING) should be included in the binary rpm
- I suggest including the provided phone_log script as %doc
17 years, 3 months
fedora-review granted: [Bug 227811] Review Request: hunspell-af - Afrikaans hunspell dictionary
by Red Hat Bugzilla
Bug 227811: Review Request: hunspell-af - Afrikaans hunspell dictionary
Product: Fedora Extras
Version: devel
Component: Package Review
manuel wolfshant <wolfy(a)nobugconsulting.ro> has granted manuel wolfshant
<wolfy(a)nobugconsulting.ro>'s request for fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227811
------- Additional Comments from manuel wolfshant <wolfy(a)nobugconsulting.ro>
Caolan: I am willing to work with you through all dictionaries.
Quick review for this package:
- unzip is not needed as BR because it's on the exception list (see
http://fedoraproject.org/wiki/Extras/FullExceptionList)
- adding -q to the %setup line and an empty %build would silence rpmlint (see
below)
Everything else seems fine
- package meets naming guidelines
- package meets packaging guidelines
- spec file legible, in am. english
- source matches upstream , sha1sum fa0dfbe45efd7eeba04e069f2e5987b721ebae71
af_ZA-pack.zip
- the package builds in mock, devel/x86_64, generates a noarch (which is
consistent with the fact that basically it includes only 3 text files)
- the license LGPL stated in the tag is the same as the web site says
- there are only 2 files (word lists) + a short doc with instructions and
license clearance, so no .la, .pc, static files
- no missing BR
- MINOR: unneeded BR: unzip
- no locales
- not relocatable
- owns all files/directories that it creates, does not take ownership of other
files/dirs
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- rpmlint output:
on source:
W: hunspell-af setup-not-quiet
W: hunspell-af no-%build-section
on binary: silent
- code, not content
- no need for -docs as the only doc is just a 31K text file
- nothing in %doc affects runtime
- no need for .desktop file
The package is APPROVED but before comitting to CVS please fix the three small
problems mentioned in the first paragraph.
17 years, 3 months
fedora-review granted: [Bug 225820] Merge Review: gnome-keyring-manager
by Red Hat Bugzilla
Bug 225820: Merge Review: gnome-keyring-manager
Product: Fedora Extras
Version: devel
Component: Package Review
Deji Akingunola <dakingun(a)gmail.com> has granted Deji Akingunola
<dakingun(a)gmail.com>'s request for fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225820
------- Additional Comments from Deji Akingunola <dakingun(a)gmail.com>
GOOD:
* Build Ok in mock (x86_64)
* License (GPL) and rpm Group tag OK
* Naming meets the packaging guildlines
* Spec file clean and legible
* Handles locales appropriately
* Buildrequires properly listed
* rpmlint silent on srpm and a warning that can be ignored on the binary
[deji@agape reviews]$ rpmlint gnome-keyring-manager-2.17.0-1.fc7.x86_64.rpm
W: gnome-keyring-manager non-conffile-in-etc
/etc/gconf/schemas/gnome-keyring-manager.schemas
* Source file matches upstream
8dc9c133ccdfb2729898a05afa177a0d gnome-keyring-manager-2.17.0.tar.bz2
NEEDSWORK:
* Complete url to the SOURCE is not provided.
APPROVED.
17 years, 3 months
fedora-review granted: [Bug 225819] Merge Review: gnome-keyring
by Red Hat Bugzilla
Bug 225819: Merge Review: gnome-keyring
Product: Fedora Extras
Version: devel
Component: Package Review
Deji Akingunola <dakingun(a)gmail.com> has granted Deji Akingunola
<dakingun(a)gmail.com>'s request for fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225819
------- Additional Comments from Deji Akingunola <dakingun(a)gmail.com>
GOOD:
* Build Ok in mock (x86_64)
* License (GPL) and rpm Group tag OK
* Naming meets the packaging guildlines
* Spec file clean and legible
* Handles locales appropriately
* Buildrequires properly listed
* rpmlint silent/OK (there's an ignorable warning on the -devel subpackages
[deji@agape reviews]$ rpmlint gnome-keyring-devel-0.7.3-1.fc7.x86_64.rpm
W: gnome-keyring-devel no-documentation)
* Source file matches upstream
4478d21d3ef56a3992411bee7ab6df73 gnome-keyring-0.7.3.tar.bz2
NEEDSWORK:
* Complete url to the SOURCE is not provided.
APPROVED.
17 years, 3 months
fedora-review granted: [Bug 225838] Merge Review: gnome-system-monitor
by Red Hat Bugzilla
Bug 225838: Merge Review: gnome-system-monitor
Product: Fedora Extras
Version: devel
Component: Package Review
Deji Akingunola <dakingun(a)gmail.com> has granted Matthias Clasen
<mclasen(a)redhat.com>'s request for fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225838
------- Additional Comments from Deji Akingunola <dakingun(a)gmail.com>
rpmlint now silent on srpm, and gives warnings (which can be ignored) on the
binary
[deji@agape reviews]$ rpmlint gnome-system-monitor-2.17.6-2.fc7.x86_64.rpm
W: gnome-system-monitor no-documentation
W: gnome-system-monitor non-conffile-in-etc
/etc/gconf/schemas/gnome-system-monitor.schemas
APPROVED.
17 years, 3 months