On Mon, 28 Oct 2019 at 14:37, Hangbin Liu liuhangbin@gmail.com wrote:
On Fri, 25 Oct 2019 at 17:55, Hangbin Liu liuhangbin@gmail.com wrote:
And after commit e47d5db538736 ("teamd: add an option to force log output to stdout, stderr or syslog"). NetworkManager will force teamd use DAEMON_LOG_SYSLOG by default. So either the user force to use option "-l stderr" or we need to implement an own filter ourselves.
Hi Jiri,
To fix the spammy log messages, there are three ways
- Ask NetworkManager reset TEAM_LOG_OUTPUT to stderr by default
- Ask libdaemon also filter DEBUG messages when using DAEMON_LOG_SYSLOG
- Move most teamd_log_dbg to teamd_log_dbgx
Which way do you prefer?
On the other hand, this issue should be there from the start. Even without NetworkManager, If we run teamd with -d option, we will use DAEMON_LOG_SYSLOG and all logs(including debug info) will print to syslog.
People start to notice this issue as the user side(NM) changes the log from stderr to syslog. It doesn't make sense to ask user side(NM) to change their code. This feature also lands in libdaemon for a long time.
So either we ignore this issue, as all looks intend to be. Or we try to move most debug messages to teamd_log_dbgx, to make the user/customer happy.
What do you think?
Thanks Hangbin
libteam@lists.fedorahosted.org