From: David Hildenbrand david@redhat.com
redhat/configs: Enable CONFIG_DEVICE_PRIVATE on aarch64
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2231407
Peter Robinson reported that the default of CONFIG_DEVICE_PRIVATE would have been "y": With common/generic/CONFIG_HSA_AMD_SVM=y (that depends on CONFIG_DEVICE_PRIVATE -- which ends up depending on CONFIG_ZONE_DEVICE) and rhel/generic/CONFIG_ZONE_DEVICE=y (that depends on CONFIG_MEMORY_HOTREMOVE), it would turn CONFIG_DEVICE_PRIVATE on as default.
However, when enabling CONFIG_MEMORY_HOTREMOVE to work around the error:
Found unset config items, please set them to an appropriate value CONFIG_DEVICE_PRIVATE=n"
We ended up setting "# CONFIG_DEVICE_PRIVATE is not set" instead, which was the wrong fix for the error.
Let's fix that by setting "CONFIG_DEVICE_PRIVATE=y" instead.
Signed-off-by: David Hildenbrand david@redhat.com
diff --git a/redhat/configs/common/generic/arm/aarch64/CONFIG_DEVICE_PRIVATE b/redhat/configs/common/generic/arm/aarch64/CONFIG_DEVICE_PRIVATE index blahblah..blahblah 100644 --- a/redhat/configs/common/generic/arm/aarch64/CONFIG_DEVICE_PRIVATE +++ b/redhat/configs/common/generic/arm/aarch64/CONFIG_DEVICE_PRIVATE @@ -1 +1 @@ -# CONFIG_DEVICE_PRIVATE is not set +CONFIG_DEVICE_PRIVATE=y
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2639
From: Brian Masney on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2639#note_1512195...
The Kconfig entry for `DEVICE_PRIVATE` in `mm/Kconfig` states: `You likely also want to select HMM_MIRROR.` I don't see this enabled on aarch64: ``` brian-x1:~/src/redhat/kernel-ark (ark-latest)$ git grep HMM_MIRROR redhat/configs/ redhat/configs/common/generic/powerpc/CONFIG_HMM_MIRROR:CONFIG_HMM_MIRROR=y redhat/configs/common/generic/x86/CONFIG_HMM_MIRROR:CONFIG_HMM_MIRROR=y ```
From: pbrobinson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2639#note_1512439...
It's selected by DRM_AMDGPU_USERPTR or HSA_AMD or HSA_AMD_SVM or INFINIBAND_ON_DEMAND_PAGING which are all enabled in common/generic so it will be enabled by default universally.
From: Brian Masney on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2639#note_1512454...
OK I see it on.
From: David Hildenbrand on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2639#note_1512456...
Thanks both, resolving this thread.
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2639#note_1521766...
@raquini @ddutile - mm review?
kernel@lists.fedoraproject.org