From: Don Zickus <dzickus(a)redhat.com>
Fix dist-get-buildreqs breakage around perl(ExtUtils::Embed)
CKI fails with
$ export missing=$(make dist-get-buildreqs | grep "Missing dependencies:" | cut
-d":" -f2)
$ if [ "$missing" == "" ]; then echo "Missing dependencies should
not be null but are empty. Review test log." && exit 1; fi;
$ dnf -y install $missing
Last metadata expiration check: 0:00:29 ago on Sat Feb 3 23:44:30 2024.
No match for argument: perl(ExtUtils
Error: Unable to find a match: perl(ExtUtils
This is because it was trying to "cut -d':' -f2" this line:
Missing dependencies: perl(ExtUtils::Embed)
And it grabbed the content between the ':', leaving out ::Embed. Easy
fix, convert cut's parameter '-f2' to '-f2-' to included everything
after the first ':'.
Running the command locally resolves the issue.
Signed-off-by: Don Zickus <dzickus(a)redhat.com>
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index blahblah..blahblah 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -461,10 +461,10 @@ test_makefile:
- git config user.name "Fedora Kernel Team"
- git config user.email "kernel-team(a)fedoraproject.org"
script:
- - export missing=$(make dist-get-buildreqs | grep "Missing dependencies:" |
cut -d":" -f2)
+ - export missing=$(make dist-get-buildreqs | grep "Missing dependencies:" |
cut -d":" -f2-)
- if [ "$missing" == "" ]; then echo "Missing dependencies
should not be null but are empty. Review test log." && exit 1; fi;
- dnf -y install $missing
- - export missingafter=$(make dist-get-buildreqs | grep "Missing
dependencies:" | cut -d":" -f2)
+ - export missingafter=$(make dist-get-buildreqs | grep "Missing
dependencies:" | cut -d":" -f2-)
- if [ "$missingafter" != "" ]; then echo "Missing
dependencies should be null but are $missingafter. Review test log." && exit
1; fi;
rules:
- *only-os-build-mr
--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2924