From: CKI Gitlab on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1369 NOTE: Truncated patchset due to missing public @redhat.com email address on your GitLab profile at https://gitlab.com/-/profile. Once that is fixed, close and reopen the merge request to retrigger sending the emails.
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
Symbol: WERROR [=y] Type : bool Defined at init/Kconfig:140 Prompt: Compile the kernel with warnings as errors Location: -> General setup
---
Cc: Prarit Bhargava prarit@redhat.com Cc: Aristeu Rozanski arozansk@redhat.com Cc: Artem Savkov asavkov@redhat.com Cc: Clark Williams williams@redhat.com Cc: "Herton R. Krzesinski" herton@redhat.com Cc: Jan Stancek jstancek@redhat.com Cc: Josh Poimboeuf jpoimboe@redhat.com Cc: Kairui Song kasong@redhat.com Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org
--- redhat/configs/common/generic/CONFIG_WERROR | 1 + redhat/configs/pending-common/generic/CONFIG_WERROR | 10 ---------- 2 files changed, 1 insertions(+), 10 deletions(-)
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1369#note_6716492...
FWIW, the build fails with CONFIG_WERROR=y on PPV and aarch64, so if we did wish to turn this on, there is work to be done.
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1369#note_6735846...
Acked-by: Prarit Bhargava prarit@redhat.com (via approve button)
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1369#note_6736108...
Acked-by: Justin M. Forbes jforbes@fedoraproject.org (via approve button)
kernel@lists.fedoraproject.org