From: Al Stone on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2083
Signed-off-by: Al Stone ahs3@redhat.com
--- redhat/configs/common/generic/arm/aarch64/CONFIG_DWMAC_TEGRA | 1 + redhat/configs/common/generic/arm/aarch64/CONFIG_SND_SOC_TEGRA_AUDIO_GRAPH_CARD | 1 + redhat/configs/common/generic/arm/aarch64/CONFIG_TEGRA_SOCTHERM | 1 + 3 files changed, 3 insertions(+), 0 deletions(-)
From: Al Stone ahs3@redhat.com
Enable Tegra SoC thermal driver
Signed-off-by: Al Stone ahs3@redhat.com
diff --git a/redhat/configs/common/generic/arm/aarch64/CONFIG_TEGRA_SOCTHERM b/redhat/configs/common/generic/arm/aarch64/CONFIG_TEGRA_SOCTHERM new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/common/generic/arm/aarch64/CONFIG_TEGRA_SOCTHERM @@ -0,0 +1 @@ +CONFIG_TEGRA_SOCTHERM=m
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2083
From: Al Stone ahs3@redhat.com
Enable Tegra audio graph card driver
Signed-off-by: Al Stone ahs3@redhat.com
diff --git a/redhat/configs/common/generic/arm/aarch64/CONFIG_SND_SOC_TEGRA_AUDIO_GRAPH_CARD b/redhat/configs/common/generic/arm/aarch64/CONFIG_SND_SOC_TEGRA_AUDIO_GRAPH_CARD new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/common/generic/arm/aarch64/CONFIG_SND_SOC_TEGRA_AUDIO_GRAPH_CARD @@ -0,0 +1 @@ +CONFIG_SND_SOC_TEGRA_AUDIO_GRAPH_CARD=m
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2083
From: Al Stone ahs3@redhat.com
Enable Tegra MGBE driver
Signed-off-by: Al Stone ahs3@redhat.com
diff --git a/redhat/configs/common/generic/arm/aarch64/CONFIG_DWMAC_TEGRA b/redhat/configs/common/generic/arm/aarch64/CONFIG_DWMAC_TEGRA new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/common/generic/arm/aarch64/CONFIG_DWMAC_TEGRA @@ -0,0 +1 @@ +CONFIG_DWMAC_TEGRA=m
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2083
From: pbrobinson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2083#note_1136442...
Overall this looks fine but a couple of notes: 1) could be some cleanup from Fedora -> Common 2) the audio graph card is useless on it's own, it needs all the other tegra audio bits.
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2083#note_1138460...
@ahs3 - we don't see any code using this config. Am I missing something (other than the defconfig file)?
From: Al Stone on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2083#note_1138715...
These were entered as a specific BZ for NVIDIA per their request; that being said, what would make more sense? Leaving this BZ as is, or moving the config items to enablement of the specific drivers? I have no real preference and was simply responding to NVIDIA's request very simplistically.
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2083#note_1138719...
I think the real concern is that the actual driver (and Kconfig entry) for CONFIG_DWMAC_TEGRA is not upstream yet, it is not even in linux-next just yet. There was discussion on the latest series as recent as last week (Oct 12), so it is very much a work in progress. If this MR goes in and you say it is "done" it really isn't because the driver is not enabled (or even present), and we would have little indication when the patch set merges upstream without having to actively watch. If that particular config item is dropped, when the driver does get merged upstream, we will get an autogenerated MR to set that driver, likely to off, but we can flip it then. At that point, we know the driver is upstream. Given that the merge window closed over the weekend, I expect this driver won't land until at least the 6.2 merge window, so 8 weeks from now or so.
From: Al Stone on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2083#note_1138823...
ACK. Then let's wait for the next merge window. I think I will replace the BZ, just the same, and add the CONFIG changes to the other BZs for enabling the specific driver. This should make things a little clearer, too.
I'll cancel this MR and submit the CONFIG enablement later on.
Thanks.
kernel@lists.fedoraproject.org