From: Ken Cox jkc@redhat.com
Enable e1000 in rhel9 as unsupported
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2002344 Upstream Status: RHEL only
Enable e1000 but also add a taint to there is no mistake that this is not supported.
Signed-off-by: Ken Cox jkc@redhat.com
diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c index blahblah..blahblah 100644 --- a/drivers/net/ethernet/intel/e1000/e1000_main.c +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c @@ -224,6 +224,9 @@ static int __init e1000_init_module(void)
pr_info("%s\n", e1000_copyright);
+ add_taint(TAINT_SUPPORT_REMOVED, LOCKDEP_STILL_OK); + pr_warn("E1000 MODULE IS NOT SUPPORTED\n"); + ret = pci_register_driver(&e1000_driver); if (copybreak != COPYBREAK_DEFAULT) { if (copybreak == 0) diff --git a/redhat/configs/ark/generic/CONFIG_E1000 b/redhat/configs/ark/generic/CONFIG_E1000 index blahblah..blahblah 100644 --- a/redhat/configs/ark/generic/CONFIG_E1000 +++ b/redhat/configs/ark/generic/CONFIG_E1000 @@ -1 +1 @@ -# CONFIG_E1000 is not set +CONFIG_E1000=m
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1382
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1382#note_6796329...
This should be wrapped in CONFIG_RHEL_DIFFERENCES so that it does not impact Fedora. It should probably also use mark_driver_unsupported rather than TAINT_SUPPORT_REMOVED.
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1382#note_6918511...
Yeah, what Justin said. Some of this was already done in another MR... was that for CentOS Stream 9? Do we want to sync the CONFIG_RHEL_DIFFERENCES bit into there as well?
From: Ken Cox on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1382#note_7210574...
Justin, Regarding mark_driver_unsupported, it looks like it only prints a warning. Don't we need to also set the tainted flag? I was using other unsupported drivers (mptsas) as a reference.
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1382#note_7211172...
That is really a RHEL call, it just seemed the natural thing to do given it exists. Either way, it needs to be wrapped, because this driver is just as supported as anything else we build for Fedora, and should not taint the Fedora kernel.
``` #ifdef CONFIG_RHEL_DIFFERENCES add_taint(TAINT_SUPPORT_REMOVED, LOCKDEP_STILL_OK); pr_warn("E1000 MODULE IS NOT SUPPORTED\n"); #endif ```
Or replace the pr_warn with mark_driver_unsupported.
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1382#note_7223007...
@prarit - what is the current policy with mark_driver_unsupported? do you know?
From: pbrobinson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1382#note_7223263...
According to a reference from elsewhere if it's enabled it's supported: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1307#note_6600234...
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1382#note_7225293...
We're in the process of discussing. See draft MR https://gitlab.com/cki- project/kernel-ark/-/merge_requests/1459
kernel@lists.fedoraproject.org