I just installed F23 (coming from F21) and encountered an irritating new behavior when trying to build a custom kernel RPM.
Patch does not have a valid e-mail address.
Well no kidding. It's a locally created (with diff) patch, not coming from a git repository.
Is there a way to disable this check?
On Sat, Nov 7, 2015 at 7:59 PM, Ian Pilcher arequipeno@gmail.com wrote:
I just installed F23 (coming from F21) and encountered an irritating new behavior when trying to build a custom kernel RPM.
Patch does not have a valid e-mail address.
Well no kidding. It's a locally created (with diff) patch, not coming from a git repository.
Is there a way to disable this check?
In a word, no. The kernel patches are applied using "git am", there's been a couple of threads on it. If you're doing the patch in a git checkout of the kernel it's easy enough to use git to create the patch.
The process I use is: git checkout -b some-name make changes git commit -a -m "quick message" "git log" to work out the hash git format-patch <previous hash to patch>
One of the easier ways to switch between branches is actually to use "fedpkg switch-branch master" and branches allow keeping master clean for easy "git pull" as it works generally. It's fairly straight forward once you get a simple work flow, there's lots of tutorials online.
Peter
On Nov 7, 2015 3:07 PM, "Peter Robinson" pbrobinson@gmail.com wrote:
On Sat, Nov 7, 2015 at 7:59 PM, Ian Pilcher arequipeno@gmail.com wrote:
I just installed F23 (coming from F21) and encountered an irritating new behavior when trying to build a custom kernel RPM.
Patch does not have a valid e-mail address.
Well no kidding. It's a locally created (with diff) patch, not coming from a git repository.
Is there a way to disable this check?
In a word, no. The kernel patches are applied using "git am", there's been a couple of threads on it. If you're doing the patch in a git checkout of the kernel it's easy enough to use git to create the patch.
The ApplyPatch function is still in the spec and can still be used.
josh
kernel@lists.fedoraproject.org