From: David Ward on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1042 NOTE: Truncated patchset due to missing @redhat.com email address on your GitLab profile at https://gitlab.com/-/profile. Once that is fixed, close and reopen the merge request to retrigger sending the emails.
These changes remove unneeded handling for debug kernels, and adjust the GRUB classes that are configured.
Signed-off-by: David Ward david.ward@ll.mit.edu
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1042#note_5609891...
While I'm not expert on grub themes, I wonder if "grub_class kernel" should be left here for compatibility, if there is any theme today which would care about it.
Another point I have also is regarding: "grub_class ${ID_LIKE:-${ID}}". From what I understand you try to keep the 10_linux behaviour. However, on RHEL ID_LIKE == fedora. So I wonder if we really should default to ID_LIKE, but instead use ID only here always. If using ID_LIKE, both rhel and fedora kernels will install with "grub_class fedora". If we use ID, fedora kernels will be "grub_class fedora" while on rhel its kernels will be "grub_class rhel".
Besides these two points, all other changes looks good to me.
kernel@lists.fedoraproject.org