From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
---
Cc: Dean Nelson dnelson@redhat.com Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org --- redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON
diff --git a/redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON b/redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON new file mode 100644 index 000000000000..e69de29bb2d1
On 11/5/20 1:24 AM, GitLab Bridge on behalf of jeremycline wrote:
From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
Cc: Dean Nelson dnelson@redhat.com Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org
redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON
diff --git a/redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON b/redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON new file mode 100644 index 000000000000..e69de29bb2d1
This file should include the text...
# CONFIG_SENSORS_INTEL_M10_BMC_HWMON is not set
From: jeremycline on gitlab.com
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
---
Cc: Dean Nelson dnelson@redhat.com Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org
From: Patrick ptalbert@redhat.com
--- redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON | 1 + 1 file changed, 1 insertion(+)
diff --git a/redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON b/redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON index e69de29bb2d1..ea5832fd5215 100644 --- a/redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON +++ b/redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON @@ -0,0 +1 @@ +# CONFIG_SENSORS_INTEL_M10_BMC_HWMON is not set \ No newline at end of file
From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
---
Cc: Dean Nelson dnelson@redhat.com Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org --- redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON
diff --git a/redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON b/redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON new file mode 100644 index 000000000000..e69de29bb2d1
From: jeremycline on gitlab.com
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
---
Cc: Dean Nelson dnelson@redhat.com Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org
From: Patrick ptalbert@redhat.com
--- redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON | 1 + 1 file changed, 1 insertion(+)
diff --git a/redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON b/redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON index e69de29bb2d1..ea5832fd5215 100644 --- a/redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON +++ b/redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON @@ -0,0 +1 @@ +# CONFIG_SENSORS_INTEL_M10_BMC_HWMON is not set \ No newline at end of file
From: Patrick ptalbert@redhat.com
--- .../configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON b/redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON index ea5832fd5215..e8cedff186a7 100644 --- a/redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON +++ b/redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON @@ -1 +1 @@ -# CONFIG_SENSORS_INTEL_M10_BMC_HWMON is not set \ No newline at end of file +# CONFIG_SENSORS_INTEL_M10_BMC_HWMON is not set
From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
---
Cc: Dean Nelson dnelson@redhat.com Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org --- redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON
diff --git a/redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON b/redhat/configs/common/generic/CONFIG_SENSORS_INTEL_M10_BMC_HWMON new file mode 100644 index 000000000000..e69de29bb2d1
From: Patrick on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/758#note_46163408...
Hey Dean,
I went ahead and updated the file. If you agree this is what should be the generic default for ARK then please give your Ack (or Nack with comment :).
Thank you,
Patrick
From: Patrick on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/758#note_46394271...
Actually, this MR was created by accident due to an issue with the MR- generating script.
The config option CONFIG_SENSORS_INTEL_M10_BMC_HWMON depends on CONFIG_MFD_INTEL_M10_BMC which is not set. So CONFIG_SENSORS_INTEL_M10_BMC_HWMON is for now irrelevant to ARK and this MR should never have been generated.
On 12/10/20 4:15 AM, GitLab Bridge on behalf of Patrick wrote:
From: Patrick on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/758#note_46394271...
Actually, this MR was created by accident due to an issue with the MR- generating script.
The config option CONFIG_SENSORS_INTEL_M10_BMC_HWMON depends on CONFIG_MFD_INTEL_M10_BMC which is not set. So CONFIG_SENSORS_INTEL_M10_BMC_HWMON is for now irrelevant to ARK and this MR should never have been generated.
I see that you closed the MR. So I'll assume that translates to this patchset as having been Nacked.
kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
kernel@lists.fedoraproject.org