From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
---
---
Cc: Jaroslav Kysela jkysela@redhat.com Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org --- redhat/configs/common/generic/CONFIG_SND_SOC_ADI_AXI_I2S | 0 redhat/configs/common/generic/CONFIG_SND_SOC_ADI_AXI_SPDIF | 0 2 files changed, 0 insertions(+), 0 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_SND_SOC_ADI_AXI_I2S create mode 100644 redhat/configs/common/generic/CONFIG_SND_SOC_ADI_AXI_SPDIF
diff --git a/redhat/configs/common/generic/CONFIG_SND_SOC_ADI_AXI_I2S b/redhat/configs/common/generic/CONFIG_SND_SOC_ADI_AXI_I2S new file mode 100644 index 000000000000..e69de29bb2d1 diff --git a/redhat/configs/common/generic/CONFIG_SND_SOC_ADI_AXI_SPDIF b/redhat/configs/common/generic/CONFIG_SND_SOC_ADI_AXI_SPDIF new file mode 100644 index 000000000000..e69de29bb2d1
From: CKI Bot on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/861#note_48769292...
Hi! This is the friendly CKI test bot.
It appears that you are not a member of redhat/red-hat-ci- tools/kernel/cki-runs/trusted-pipelines. This means that the CI pipeline on your MR will fail. As getting testing is important, I'll be responsible for testing your changes. After every MR change, I'll start a small testing pipeline and link it here so you can follow the results. I'll also create and link a pipeline for hardware testing that the reviewers can start to get extra test coverage.
From: CKI Bot on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/861#note_48769304...
Testing pipeline status: Basic testing pipeline:
https://gitlab.com/redhat/red-hat-ci-tools/kernel/cki- runs/external-pipelines/-/pipelines/243141272 - created :hourglass_flowing_sand:
From: Jaroslav Kysela on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/861#note_48771653...
This kconfig settings should be off. It's only for some reference boards from Analog Devices.
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/861#note_48887192...
request-evaluation
From: CKI Bot on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/861#note_48887198...
ACK/NACK Summary: NeedsReview - Requires at least 1 ACK(s) from someone in the set trix@redhat.com★, fhrbata@redhat.com★, williams@redhat.com★, bmeneg@redhat.com★, jkysela@redhat.com★, lgoncalv@redhat.com★, dvlasenk@redhat.com★, ptalbert@redhat.com★, acaringi@redhat.com★, jforbes@redhat.com★, jstancek@redhat.com★, herton@redhat.com★, dzickus@redhat.com★, jlelli@redhat.com★, rvrbovsk@redhat.com★, bmasney@redhat.com★. Code owners are marked with a ★.
From: Jaroslav Kysela on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/861#note_48890835...
I don't understand this zero-change proposal.
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/861#note_48912579...
@ptalbert - it appears there is a bug in the configuration scripts as there is no change here, other than empty files added. I am think we close this MR. Or do you think there is something to do but the script screwed it up?
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/861#note_49155195...
I guess in redhat/configs/process_configs.sh it ran 'make listnewconfig' and for some reason that spat out these two items.
SND_SOC_ADI_AXI_SPDIF and SND_SOC_ADI_AXI_I2S depend on CONFIG_SND_SOC_ADI which is not enabled for ark or common. So yeah these options are irrelevant.
kernel@lists.fedoraproject.org