commit b03a355ada533ec104fbcce27ea8bed5eab45fa7 Author: Stanislav Ochotnicky sochotnicky@redhat.com Date: Thu Oct 3 11:24:20 2013 +0200
[artifact] Improve error messages for from_mvn_str
python/javapackages/artifact.py | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) --- diff --git a/python/javapackages/artifact.py b/python/javapackages/artifact.py index 6b041d4..f0414d9 100644 --- a/python/javapackages/artifact.py +++ b/python/javapackages/artifact.py @@ -221,9 +221,13 @@ class Artifact(object): tup = mvnstr.split(":")
# groupId and artifactId are always present - if not (2 <= len(tup) <= 5): - raise ArtifactFormatException("Unable to create Artifact from " - "supplied arguments ({mvnstr})".format(mvnstr=mvnstr)) + if len(tup) < 2: + raise ArtifactFormatException("Artifact string '{mvnstr}' does not " + "contain ':' character. Can not parse".format(mvnstr=mvnstr)) + + if len(tup) > 5: + raise ArtifactFormatException("Artifact string '{mvnstr}' contains " + "too many colons. Can not parse".format(mvnstr=mvnstr))
groupId = tup[0] artifactId = tup[1]