On 06/25/2012 09:14 PM, Bill Nottingham wrote:
Michal Schmidt (mschmidt(a)redhat.com) said:
> + mkdir -p -m 755 $(ROOT)/usr/lib/initscripts/legacy-actions
If this isn't configurable based on $prefix...
> +%dir %{_prefix}/lib/initscripts/legacy-actions
... this shouldn't be either. (I'd drop it here, rather than trying to wire
$prefix throughout the infrastructure - it's not as if initscripts supports
rewiring $sysconfdir
Agreed.
> +ACTIONDIR="/usr/lib/initscripts/legacy-actions"
Opinions on /usr/libexec/initscripts or /usr/share/initscripts instead?
Hardcoded /usr/lib follows the systemd/udev example, but it isn't very
traditional.
I don't have a strong preference between /usr/libexec and /usr/lib.
But using /usr/share would exclude the (admittedly low valued)
possibility of implementing the actions as executable binaries.
Michal