Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=787564
--- Comment #4 from James Ni <jni(a)redhat.com> 2012-02-07 02:05:44 EST ---
Hi Morabity
Thanks a lot for your comments, I just update the spec file and source code
base on your comment:
Spec URL:
http://jamesni.fedorapeople.org/fonts-tweak-tool/fonts-tweak-tool.spec
SRPM URL:
http://jamesni.fedorapeople.org/fonts-tweak-tool/fonts-tweak-tool-0.0.2-1.f…
Basically, I update the licenses file to LGPLv3+, as well as the header of
source files. The spec file is modified based on your comment. I also add a
desktop file in package following the guideline you provided. I also try
rpmlint on my side, it seems everything works fine.
I didn't meet the errors you meet, i install the rpm in a new installed
Fedora16 and then run "yum install libeasyfc*" to install all the packages of
libeasyfc, after that i run fonts-tweak-tool, the program works as expected.
So could you try again?
Best Regards
James
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=787564
--- Comment #3 from Mohamed El Morabity <pikachu.2014(a)gmail.com> 2012-02-06 19:47:56 EST ---
(In reply to comment #2)
> - I don't think the version condition on libeasyfc is necessary, since only
> Fedora 16 and Rawhide provide libeasyfc, at version 0.5.
Rawhide has version 0.6, in fact. But it doesn't change my advice about the
version ;)
By the way, since your package seems to require pygobject3 and gtk3, you must
add them as Requires in your .spec file.
Moreover, since fonts-tweak-tool is a graphical tool, you must provide a
.desktop file:
http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files
If you need an icon for your project, you could request the Design team
(http://fedoraproject.org/wiki/Design#What_We_Do) to draw one:
https://fedorahosted.org/design-team/newticket
I tried to test your application, but I get this error under Fedora 16:
---
$ fonts-tweak-tool
ERROR:root:Could not find any typelib for Easyfc
Traceback (most recent call last):
File "/usr/bin/fonts-tweak-tool", line 23, in <module>
from fontstweak import tool
File "/usr/lib/python2.7/site-packages/fontstweak/tool.py", line 30, in
<module>
from gi.repository import Easyfc
ImportError: cannot import name Easyfc
---
The libeasyfc package is obviously installed (v. 0.5), as well as
libeasyfc-gobject
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=787564
--- Comment #2 from Mohamed El Morabity <pikachu.2014(a)gmail.com> 2012-02-06 19:19:40 EST ---
Some rpmlint issues:
---
rpmlint -i
/home/mohamed/rpmbuild/RPMS/noarch/fonts-tweak-tool-0.0.1-1.fc16.noarch.rpm
fonts-tweak-tool.noarch: W: spelling-error %description -l en_US fontconfig ->
configuration
The value of this tag appears to be misspelled. Please double-check.
fonts-tweak-tool.noarch: E: description-line-too-long C fonts-tweak-tool is a
GUI tool for customizing fonts per language on desktops using fontconfig.
Your description lines must not exceed 80 characters. If a line is exceeding
this number, cut it to fit in two lines.
fonts-tweak-tool.noarch: W: invalid-url URL:
https://github.com/downloads/jamesni/fonts-tweak-tool HTTP Error 404: Not Found
The value should be a valid, public HTTP, HTTPS, or FTP URL.
fonts-tweak-tool.noarch: E: incorrect-fsf-address /usr/bin/fonts-tweak-tool
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
fonts-tweak-tool.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/fontstweak/tool.py
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
fonts-tweak-tool.noarch: W: no-manual-page-for-binary fonts-tweak-tool
Each executable in standard binary directories should have a man page.
1 packages and 0 specfiles checked; 3 errors, 3 warnings.
---
You can ignore the spelling issues, they are false positive. You can also skip
the missing man page issue, it's not mandatory to have one. But the other
warnings/errors must be solved:
- I suppose the correct URL is https://github.com/jamesni/fonts-tweak-tool
- since you are the developer of font-tweak-tools, you should really fix the
FSF address in the comments of your source code
Now about the .spec file:
- you don't need anymore to set the %python_sitelib macro, its definition is
now provided by the rpm package:
http://fedoraproject.org/wiki/Packaging:Python#Macros
- the summary is maybe too mysterious: something like " Tool for customizing
fonts per language" may be more explicit, or any other description, at your
convenience
- the Group tag "Development/Tools" is maybe far from corresponding to your
tool. Something like "User Interface/Desktops" is more appropriate.
- You could really take advantage of macros in the Source0 URL:
Source0:
https://github.com/downloads/jamesni/fonts-tweak-tool/%{name}-%{version}.ta…
- The BuildRoot tag is not needed anymore, as well as cleaning the build root
(occurrences "rm -rf $RPM_BUILD_ROOT" can be dropped):
http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
- I suggest you to replace "python-setuptools" by "python2-setuptools" in your
BuildRequires, in case Fedora switches to Python 3 by default.
- I don't think the version condition on libeasyfc is necessary, since only
Fedora 16 and Rawhide provide libeasyfc, at version 0.5.
- The %defattr macro is useless now in %files:
http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
- The %clean target is useless too:
http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=787564
Mohamed El Morabity <pikachu.2014(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |pikachu.2014(a)gmail.com
AssignedTo|nobody(a)fedoraproject.org |pikachu.2014(a)gmail.com
--- Comment #1 from Mohamed El Morabity <pikachu.2014(a)gmail.com> 2012-02-06 09:47:37 EST ---
I will review this package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=787564
Akira TAGOH <tagoh(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |i18n-bugs(a)lists.fedoraproje
| |ct.org, tagoh(a)redhat.com
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=756595
Jens Petersen <petersen(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Accessibility Ctrl-space |ibus Ctrl+Space conflicts
|kills content assist in |with Eclipse's Content
|eclipse |Assist and various other
| |IDEs/editors
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: test
https://bugzilla.redhat.com/show_bug.cgi?id=787535
Summary: test
Product: Fedora
Version: 16
Platform: Unspecified
OS/Version: Unspecified
Status: NEW
Severity: unspecified
Priority: unspecified
Component: vlgothic-fonts
AssignedTo: tagoh(a)redhat.com
ReportedBy: tagoh(a)redhat.com
QAContact: extras-qa(a)fedoraproject.org
CC: tagoh(a)redhat.com, fonts-bugs(a)lists.fedoraproject.org,
i18n-bugs(a)lists.fedoraproject.org
Classification: Fedora
Story Points: ---
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Description of problem:
Version-Release number of selected component (if applicable):
How reproducible:
Steps to Reproduce:
1.
2.
3.
Actual results:
Expected results:
Additional info:
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.