On Wed, Mar 14, 2018 at 09:11:20AM -0500, Ian Pilcher via FreeIPA-devel wrote:
On 03/11/2018 09:31 PM, Fraser Tweedale wrote:
> Thanks Ian! I'll try and review this in the next couple of days?
No rush. I'm traveling this week, so I won't be to do anything with
this anyway.
> Do you use GitHub? If so, you could create a pull request there,
> which will make it more visible, easier to review, and cause CI to
> run on your patch. If not, that's OK. We are happy to receive your
> contribution by any means!
Define use. ;-)
I have an ID, but my git usage has been limited to basic clone/pull/
push stuff. Learning how to do a pull request would not be a bad thing,
though.
To that end, I've tried to follow/adapt this page:
https://www.freeipa.org/page/Pull_request_on_Github
But I haven't been able to push anything to my new github repo. I
keep getting "The remote end hung up unexpectedly" errors.
Is there updated/better documentation anywhere?
Hi Ian,
Looks like you have not created a "fork" on GitHub yet.
Go to
https://github.com/freeipa/freeipa and hit the "Fork" button
(top right). Then do the `git remote add', push your feature branch
to your freeipa repo (the fork), and return to
GitHub.com to create
the pull request.
Let me know if you still get stuck.
Cheers,
Fraser