On 05/03/2018 08:59 PM, Rob Crittenden via FreeIPA-devel wrote:
There are a lot of old, outdated PRs.
I think we need to close them and strive hard to keep the list of PRs
very low so for this round, against my usual instincts, I propose we act
on the harsher side. Note that I did __not__ review the patches in
detail, I'm mostly look at at last touch and relevance.
If we don't close them outright then some pushing on the contributor
will be needed including a timeframe to respond.
I think that for any closed PRs we attach a copy of the patches to the
associated ticket (and mention the remote branch) so we don't lose
anything.
Here is my list of PRs to close and the reasoning:
https://github.com/freeipa/freeipa/pull/1793 - needs rebase (2 weeks),
failing test needs investigation.
https://github.com/freeipa/freeipa/pull/1559 appears to be a duplicate
of this.
https://github.com/freeipa/freeipa/pull/1809 - Needs response to
reviewers, including, and most importantly, showing that the test
succeeds by a temporary patch to execute it.
https://github.com/freeipa/freeipa/pull/1724 - There is confusion over
what branch this needs to land in.
https://github.com/freeipa/freeipa/pull/1650 - Doesn't seem to have
agreement that this is needed
https://github.com/freeipa/freeipa/pull/1563 - Was a good,
forwarding-looking change but given William's departure are we likely to
see this fixed anytime soon?
https://github.com/freeipa/freeipa/pull/1515 - been waiting weeks for
contributor to address comments of reviewer
There is new activity on this one, let's keep it.
Flo
https://github.com/freeipa/freeipa/pull/1460 - been waiting months
for
contributor to address comments of reviewers
https://github.com/freeipa/freeipa/pull/1430 - been waiting weeks for
reviewer comments to be addressed
https://github.com/freeipa/freeipa/pull/1421 - still waiting on
contributor to update
https://github.com/freeipa/freeipa/pull/1378 - been waiting months for
contributor to address comments of reviewers
https://github.com/freeipa/freeipa/pull/1353 - WIP patch. Is it still
needed?
https://github.com/freeipa/freeipa/pull/1188 - been waiting months for
rebase
https://github.com/freeipa/freeipa/pull/920 - reviewer restarted work a
month ago, do we want to keep this open?
What to do with the 2 postponed PRs? Will we ever get to them?
https://github.com/freeipa/freeipa/pull/717 - I don't think we will ever
finish this
https://github.com/freeipa/freeipa/pull/433 - same as above
And then there are these two which are planned changes that have been
lost to the depths of time:
https://github.com/freeipa/freeipa/pull/117 - What is the priority of
this? It is in the 4.7 milestone.
https://github.com/freeipa/freeipa/pull/23 - What to do with this, it
was planned for 4.5? Does it need coordination with SSSD to do the time
enforcement?
rob
_______________________________________________
FreeIPA-devel mailing list -- freeipa-devel(a)lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-leave(a)lists.fedorahosted.org