On Mon, Nov 26, 2012 at 10:01 AM, Marcela Mašláňová <mmaslano(a)redhat.com> wrote:
Well, I wanted to say 4 in strncmp(MailCmd, "off", 4) is
really ugly, but I
found out, that the same code is already in cronie. So, ack.
I agree. User input validation could be more robust. To me it would
make sense to investigate the MailCmd as whole, and if it is specified
verify that at least the mail command exists.
I also find it it a bit strange that there is debug command line
option and compile time definition. Surely the later should be made
dynamic, e.g., usable on user request without recompilation. Fixing
that should not be too much of a problem, but lets process the first
patch set before writing new stuff.
--
Sami Kerola
http://www.iki.fi/kerolasa/