Change in vdsm[master]: net: api: return networks to connectivity check from setup

edwardh at redhat.com edwardh at redhat.com
Sat Feb 20 23:43:04 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: api: return networks to connectivity check from setup
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/53757/2/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 701: connectivity_check_networks
This func does not 'know' about connectivity check stuff, it can just report which networks got added.

So maybe a better name will be 'nets_added'.

BTW: What about just reading netinfo networks and using that instead?


Line 885: connectivity_check_networks
Good opportunity to change the naming and describe which networks we want to check connectivity for.


-- 
To view, visit https://gerrit.ovirt.org/53757
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57b557442fe6b2324cda19a8d3917cb8221268a7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list