Change in vdsm[master]: net: api: return networks to connectivity check from setup

danken at redhat.com danken at redhat.com
Fri Feb 19 20:12:15 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: net: api: return networks to connectivity check from setup
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/53757/2/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 720:                                          configurator)
Line 721:             raise
Line 722:         connectivity_check_networks.add(network)
Line 723: 
Line 724:         _netinfo.updateDevices()  # Things like a bond mtu can change
missing return?
Line 725: 
Line 726: 
Line 727: def _get_connectivity_timeout(options):
Line 728:     return int(options.get('connectivityTimeout',


-- 
To view, visit https://gerrit.ovirt.org/53757
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57b557442fe6b2324cda19a8d3917cb8221268a7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list