Change in vdsm[master]: net: api: return networks to connectivity check from setup

phoracek at redhat.com phoracek at redhat.com
Mon Feb 22 10:33:00 UTC 2016


Petr Horáček has posted comments on this change.

Change subject: net: api: return networks to connectivity check from setup
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/53757/2/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 697: def _add_missing_networks(configurator, networks, bondings, logger, _netinfo):
Line 698:     # We need to use the newest host info
Line 699:     _netinfo.updateDevices()
Line 700: 
Line 701:     connectivity_check_networks = set()
> This func does not 'know' about connectivity check stuff, it can just repor
good point.

maybe. i'm not 100% sure, but i think we can drop the whole connectivity_check_networks, it was needed only for implicit networks-bondings. but it's just a suspicion now.
Line 702: 
Line 703:     for network, attrs in networks.iteritems():
Line 704:         if 'remove' in attrs:
Line 705:             continue


Line 720:                                          configurator)
Line 721:             raise
Line 722:         connectivity_check_networks.add(network)
Line 723: 
Line 724:         _netinfo.updateDevices()  # Things like a bond mtu can change
> missing return?
sure, thanks
Line 725: 
Line 726: 
Line 727: def _get_connectivity_timeout(options):
Line 728:     return int(options.get('connectivityTimeout',


-- 
To view, visit https://gerrit.ovirt.org/53757
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57b557442fe6b2324cda19a8d3917cb8221268a7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list