Change in vdsm[master]: Apply storage QoS on running VM

fromani at redhat.com fromani at redhat.com
Wed Feb 17 16:04:40 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: Apply storage QoS on running VM
......................................................................


Patch Set 11:

(2 comments)

thanks for the changes. Initial review.

https://gerrit.ovirt.org/#/c/52746/11/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2495:                     return response.error('noVM')
Line 2496:                 else:
Line 2497:                     return response.error('updateVmPolicyErr', e.message)
Line 2498: 
Line 2499:         return response.success()
nice! but unrelated, please keep the patch minimal
Line 2500: 
Line 2501:     def _getVmPolicy(self):
Line 2502:         """
Line 2503:         This method gets the current qos block from the libvirt metadata.


Line 2627:             self.log.info("New device XML for %s: %s",
Line 2628:                           found_device.name, xml)
Line 2629:             found_device._deviceXML = xml
Line 2630: 
Line 2631:         return response.success()
nice, but unrelated. Please keep the patch minimal
Line 2632: 
Line 2633:     def _createTransientDisk(self, diskParams):
Line 2634:         if (diskParams.get('shared', None) !=
Line 2635:            vmdevices.storage.DRIVE_SHARED_TYPE.TRANSIENT):


-- 
To view, visit https://gerrit.ovirt.org/52746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f5fcb8705c974f1d91c90cdb3158d2e8dd314f8
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir at redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list