Change in vdsm[master]: Apply storage QoS on running VM

fromani at redhat.com fromani at redhat.com
Wed Feb 17 15:58:04 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: Apply storage QoS on running VM
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/52746/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2394:                     (not hasDomainID or dev.domainID == domainId) and
         :                     (not hasPoolID or dev.poolID == poolId) and
         :                     (not hasImageID or dev.imageID == imageId) and
         :                     (not hasVolumeID or dev.volumeID == volumeId)):
> I was not sure, if all of them have to be providied to identify a disk.
Yes, this is what I mean. I expect all of four to be present, otherwise it is just a bug. If you have a counter example please provide it!


-- 
To view, visit https://gerrit.ovirt.org/52746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f5fcb8705c974f1d91c90cdb3158d2e8dd314f8
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir at redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list