Change in vdsm[master]: net: api: remove bonding handling from _addNetwork
phoracek at redhat.com
phoracek at redhat.com
Wed Feb 17 16:09:48 UTC 2016
Petr Horáček has posted comments on this change.
Change subject: net: api: remove bonding handling from _addNetwork
......................................................................
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/53475/11/lib/vdsm/network/models.py
File lib/vdsm/network/models.py:
Line 272: _netinfo=_netinfo))
Line 273: return slaves
Line 274:
Line 275: @classmethod
Line 276: def objectivize(cls, name, configurator, _netinfo, options=None,
> I like less defaults...
yes, i guess
Line 277: nics=None, mtu=None, destroyOnMasterRemoval=None):
Line 278:
Line 279: if nics: # New bonding or edit bonding.
Line 280: slaves = cls._objectivizeSlaves(name, configurator, _nicSort(nics),
--
To view, visit https://gerrit.ovirt.org/53475
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20c79bc8e3d8a0db5e814ad91fa9fcf8ca71be04
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list