Change in vdsm[master]: Refactor metadata operations

alitke at redhat.com alitke at redhat.com
Wed Apr 20 16:06:48 UTC 2016


Adam Litke has posted comments on this change.

Change subject: Refactor metadata operations
......................................................................


Patch Set 3:

(3 comments)

https://gerrit.ovirt.org/#/c/52671/3/tests/storage_volume_metadata_test.py
File tests/storage_volume_metadata_test.py:

Line 50: 
Line 51:     def test_create_info(self):
Line 52:         params = get_params()
Line 53:         expected = dict(
Line 54:             CTIME=FAKE_TIME,
expect string here.
Line 55:             DESCRIPTION=params['description'],
Line 56:             DISKTYPE=params['disk_type'],
Line 57:             DOMAIN=params['sd_id'],
Line 58:             FORMAT=params['vol_format'],


Line 57:             DOMAIN=params['sd_id'],
Line 58:             FORMAT=params['vol_format'],
Line 59:             IMAGE=params['img_id'],
Line 60:             LEGALITY=params['legality'],
Line 61:             MTIME=0,
expect string
Line 62:             POOL_UUID='',
Line 63:             PUUID=params['parent_vol_id'],
Line 64:             SIZE=params['size'],
Line 65:             TYPE=params['prealloc'],


Line 60:             LEGALITY=params['legality'],
Line 61:             MTIME=0,
Line 62:             POOL_UUID='',
Line 63:             PUUID=params['parent_vol_id'],
Line 64:             SIZE=params['size'],
expect string
Line 65:             TYPE=params['prealloc'],
Line 66:             VOLTYPE=params['vol_type'])
Line 67: 
Line 68:         with MonkeyPatchScope([[time, 'time', lambda: FAKE_TIME]]):


-- 
To view, visit https://gerrit.ovirt.org/52671
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee56b30c13a3c1cede8489338ed60f4e1d5eab
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list