Change in vdsm[master]: Refactor metadata operations

alitke at redhat.com alitke at redhat.com
Wed Apr 20 15:59:31 UTC 2016


Adam Litke has posted comments on this change.

Change subject: Refactor metadata operations
......................................................................


Patch Set 3:

(5 comments)

https://gerrit.ovirt.org/#/c/52671/3/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 177:                  legality=ILLEGAL_VOL, ctime=None, mtime=None):
Line 178:         self.sd_id = sd_id
Line 179:         self.img_id = img_id
Line 180:         self.parent_vol_id = parent_vol_id
Line 181:         self.size = size
assert size is an integer
Line 182:         self.vol_format = vol_format
Line 183:         self.prealloc = prealloc
Line 184:         self.vol_type = vol_type
Line 185:         self.disk_type = disk_type


Line 185:         self.disk_type = disk_type
Line 186:         self.description = description
Line 187:         self.legality = legality
Line 188:         self.ctime = int(time.time()) if not ctime else ctime
Line 189:         self.mtime = 0 if not mtime else mtime
assert times are integers if given.
Line 190: 
Line 191:     @property
Line 192:     def description(self):
Line 193:         return self._description


Line 231:             FORMAT: self.vol_format,
Line 232:             TYPE: self.prealloc,
Line 233:             VOLTYPE: self.vol_type,
Line 234:             DISKTYPE: self.disk_type,
Line 235:             SIZE: self.size,
str()
Line 236:             CTIME: self.ctime,
Line 237:             sd.DMDK_POOLS: "",  # obsolete
Line 238:             DOMAIN: self.sd_id,
Line 239:             IMAGE: self.img_id,


Line 232:             TYPE: self.prealloc,
Line 233:             VOLTYPE: self.vol_type,
Line 234:             DISKTYPE: self.disk_type,
Line 235:             SIZE: self.size,
Line 236:             CTIME: self.ctime,
str()
Line 237:             sd.DMDK_POOLS: "",  # obsolete
Line 238:             DOMAIN: self.sd_id,
Line 239:             IMAGE: self.img_id,
Line 240:             DESCRIPTION: self.description,


Line 238:             DOMAIN: self.sd_id,
Line 239:             IMAGE: self.img_id,
Line 240:             DESCRIPTION: self.description,
Line 241:             PUUID: self.parent_vol_id,
Line 242:             MTIME: self.mtime,
str()
Line 243:             LEGALITY: self.legality,
Line 244:         }
Line 245: 
Line 246: 


-- 
To view, visit https://gerrit.ovirt.org/52671
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee56b30c13a3c1cede8489338ed60f4e1d5eab
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list