Change in vdsm[master]: VolumeMetadata: Add from_lines factory method
alitke at redhat.com
alitke at redhat.com
Wed Apr 20 16:13:15 UTC 2016
Adam Litke has posted comments on this change.
Change subject: VolumeMetadata: Add from_lines factory method
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/52672/3/vdsm/storage/volume.py
File vdsm/storage/volume.py:
Line 219: continue
Line 220: try:
Line 221: param = cls.MD_FIELDS[key]
Line 222: except KeyError:
Line 223: raise se.VolumeMetadataReadError("Invalid key: %s" % key)
don't raise here (breaks compatibility). Just log bad line and continue.
Line 224:
Line 225: kwargs[param] = int(value) if key in cls.INT_KEYS else value
Line 226: return cls(**kwargs)
Line 227:
--
To view, visit https://gerrit.ovirt.org/52672
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7f63dce8e42e99d3240f4e916a9bd6ee5ee4b61
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list