Change in vdsm[master]: VolumeMetadata: Metadata read utils

nsoffer at redhat.com nsoffer at redhat.com
Wed Nov 25 00:46:28 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: VolumeMetadata: Metadata read utils
......................................................................


Patch Set 18:

(1 comment)

https://gerrit.ovirt.org/#/c/41846/18/vdsm/storage/blockVolume.py
File vdsm/storage/blockVolume.py:

Line 108:             meta = misc.readblock(lvm.lvPath(vgname, sd.METADATA),
Line 109:                                   offs * volume.METADATA_SIZE,
Line 110:                                   volume.METADATA_SIZE)
Line 111:             out = {}
Line 112:             for l in meta:
> this logic seems similar to the one in fileVolume, can't we reuse it?
We should but not now.

We only move code needed for sdm. We will work on removing duplication later, since the our goal is removing the spm. Anything else is not a priority now.

Also, changing this code require adding tests, and this code is known to be hard to test.

Adam, can you add some TODO: comments when you see stuff that needs more work later?
Line 113:                 if l.startswith("EOF"):
Line 114:                     return out
Line 115:                 if l.find("=") < 0:
Line 116:                     continue


-- 
To view, visit https://gerrit.ovirt.org/41846
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e02ad8138bae0b1d60b032662afbad15dd4feba
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list