Change in vdsm[master]: VolumeMetadata: move getVolumeSize

nsoffer at redhat.com nsoffer at redhat.com
Wed Nov 25 00:53:42 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: VolumeMetadata: move getVolumeSize
......................................................................


Patch Set 17: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/41998/17/vdsm/storage/blockVolume.py
File vdsm/storage/blockVolume.py:

Line 202:         """
Line 203:         # Just call the SD Manifest method getVSize() - apparently it does what
Line 204:         # we need. We consider incurred overhead of producing the object
Line 205:         # to be a small price for code de-duplication.
Line 206:         manifest = blockSD.BlockStorageDomainManifest(self.sdUUID)
This bypass the sd cache, which is nice, since I like to get rid of it. But since we still use the sdcache elsewhere, this create inconsistency. While other code will be block on sdcache refresh, this code will bypass the cache and access storage directly, possibly failing in new unexpected ways compared to code blocked on the sdcache.

Lets keep things simpler for now, and use the sdcache as is.
Line 207:         return int(manifest.getVSize(self.imgUUID, self.volUUID) / bs)
Line 208: 
Line 209:     getVolumeTrueSize = getVolumeSize
Line 210: 


-- 
To view, visit https://gerrit.ovirt.org/41998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie122d4c96ad81d31c0e783e8651a99328722f8ed
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list