Change in vdsm[master]: build: Cleanup conditionals in the build system

nsoffer at redhat.com nsoffer at redhat.com
Tue Nov 24 23:21:51 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: build: Cleanup conditionals in the build system
......................................................................


Patch Set 18: -Code-Review

(1 comment)

https://gerrit.ovirt.org/#/c/48446/18/vdsm.spec.in
File vdsm.spec.in:

Line 636
Line 637
Line 638
Line 639
Line 640
> Nice!
Are all these flags implemented in our configure script?

I think we need to add variables like with_gluster_mgmt in the spec, and use them here:

    %if %{with_smbios_manufactuerer}
       --with-smbios-manufacturer='Red Hat'
    %endif

Otherwise we will get the defaults in the build. Unless these values are created by configure in another file during configure.


-- 
To view, visit https://gerrit.ovirt.org/48446
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c94d206eb94ba51752423831ce4e01214a6a6d3
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list