Change in vdsm[master]: network: support PCI passthrough of SR-IOV network interfaces.

mpolednik at redhat.com mpolednik at redhat.com
Wed Mar 4 10:58:49 UTC 2015


Martin Polednik has posted comments on this change.

Change subject: network: support PCI passthrough of SR-IOV network interfaces.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/38249/2/vdsm/virt/vmdevices/hwclass.py
File vdsm/virt/vmdevices/hwclass.py:

Line 33: CONSOLE = 'console'
Line 34: SMARTCARD = 'smartcard'
Line 35: TPM = 'tpm'
Line 36: HOSTDEV = 'hostdev'
Line 37: INTERFACE = 'interface'
> I used host HostDevice. It's rebased on your changed.
The issue is, in vm.py we're populating vm._devices using this as keys. a) you're missing the code there for this key and b) since there are device routines, that iterate over all e.g. vm._devices[hwclass.HOSTDEV] you should reuse the hostdev and not create a new class.


-- 
To view, visit https://gerrit.ovirt.org/38249
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib962fbf1bb08cd5b82b649cc05612471e4e4d0b8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list