Change in vdsm[master]: network: support PCI passthrough of SR-IOV network interfaces.

danken at redhat.com danken at redhat.com
Wed Mar 4 11:22:09 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: network: support PCI passthrough of SR-IOV network interfaces.
......................................................................


Patch Set 5: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/38249/5/vdsm/virt/vmdevices/hostdevice.py
File vdsm/virt/vmdevices/hostdevice.py:

Line 74
Line 75
Line 76
Line 77
Line 78
killing this whitespace is not related to the patch.


https://gerrit.ovirt.org/#/c/38249/5/vdsm/virt/vmdevices/hwclass.py
File vdsm/virt/vmdevices/hwclass.py:

Line 33: CONSOLE = 'console'
Line 34: SMARTCARD = 'smartcard'
Line 35: TPM = 'tpm'
Line 36: HOSTDEV = 'hostdev'
Line 37: INTERFACE = 'interface'
We already have a NIC, with the same string as value.


-- 
To view, visit https://gerrit.ovirt.org/38249
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib962fbf1bb08cd5b82b649cc05612471e4e4d0b8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list