Change in vdsm[master]: network: support PCI passthrough of SR-IOV network interfaces.

ibarkan at redhat.com ibarkan at redhat.com
Wed Mar 4 09:44:13 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: network: support PCI passthrough of SR-IOV network interfaces.
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/38249/4/vdsm/virt/vmdevices/hostdevice.py
File vdsm/virt/vmdevices/hostdevice.py:

Line 28: 
Line 29:     def __init__(self, conf, log, **kwargs):
Line 30:         super(HostDevice, self).__init__(conf, log, **kwargs)
Line 31:         self._deviceParams = {}
Line 32:         self.macAddr = kwargs.get('mac_address')
> shouldn't this be macAddr
Done
Line 33: 
Line 34:     def detach(self):
Line 35:         """
Line 36:         Detach the device from the host. This method *must* be


-- 
To view, visit https://gerrit.ovirt.org/38249
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib962fbf1bb08cd5b82b649cc05612471e4e4d0b8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list