Change in vdsm[ovirt-3.4]: networkTests: BOND_NAME constant changed to bond11

phoracek at redhat.com phoracek at redhat.com
Tue Sep 30 10:54:12 UTC 2014


Hello Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/33529

to review the following change.

Change subject: networkTests: BOND_NAME constant changed to bond11
......................................................................

networkTests: BOND_NAME constant changed to bond11

getVdsCaps on rhel6 reports bond0-4 as existing
regardless of their true existence (see
_report_legacy_bondings).

This confuses the testing changes in upcoming
patches, hence we prefer to test a bond name with
no legacy burdens.

Change-Id: Id9f1892eaeae68583a792cb122cad4a5162e68fa
Signed-off-by: Petr Horáček <phoracek at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31332
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Tested-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/functional/networkTests.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/33529/1

diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 141b47b..cbc6d0a 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -46,7 +46,7 @@
 
 NETWORK_NAME = 'test-network'
 VLAN_ID = '27'
-BONDING_NAME = 'bond0'
+BONDING_NAME = 'bond11'
 IP_ADDRESS = '240.0.0.1'
 IP_NETWORK = '240.0.0.0'
 IP_ADDRESS_IN_NETWORK = '240.0.0.50'


-- 
To view, visit http://gerrit.ovirt.org/33529
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9f1892eaeae68583a792cb122cad4a5162e68fa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list