Change in vdsm[master]: jsonrpc: hotunplug spelling issue

danken at redhat.com danken at redhat.com
Tue Sep 30 10:41:57 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: jsonrpc: hotunplug spelling issue
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/33484/2/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:

Line 446:     'VM_getStats': {'ret': 'statsList'},
Line 447:     'VM_hotplugDisk': {'ret': 'vmList'},
Line 448:     'VM_hotplugNic': {'ret': 'vmList'},
Line 449:     'VM_hotunplugDisk': {'ret': 'vmList'},
Line 450:     'VM_hotunplugNic': {'ret': 'vmList'},
omg!
Line 451:     'VM_mergeStatus': {'ret': 'mergeStatus'},
Line 452:     'VM_migrationCreate': {'ret': VM_migrationCreate_Ret},
Line 453:     'VM_setNumberOfCpus': {'ret': 'vmList'},
Line 454:     'VM_getIoTunePolicy': {'ret': 'ioTunePolicyList'},


-- 
To view, visit http://gerrit.ovirt.org/33484
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic95a94da36ca3a6dc005c8cf0cd705b4cf87b81a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list