Change in vdsm[ovirt-3.4]: networkTests: BOND_NAME constant changed to bond11

danken at redhat.com danken at redhat.com
Tue Sep 30 11:19:31 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: networkTests: BOND_NAME constant changed to bond11
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/33529/2//COMMIT_MSG
Commit Message:

Line 12: 
Line 13: This confuses the testing changes in upcoming
Line 14: patches, hence we prefer to test a bond name with
Line 15: no legacy burdens.
Line 16: 
please explain why this is needed for a backport - do we really intend to backport these "upcoming patches"?

Also, please first backport to ovirt-3.5 branch.
Line 17: Change-Id: Id9f1892eaeae68583a792cb122cad4a5162e68fa
Line 18: Signed-off-by: Petr Horáček <phoracek at redhat.com>
Line 19: Reviewed-on: http://gerrit.ovirt.org/31332
Line 20: Reviewed-by: Dan Kenigsberg <danken at redhat.com>


-- 
To view, visit http://gerrit.ovirt.org/33529
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9f1892eaeae68583a792cb122cad4a5162e68fa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list