Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required

danken at redhat.com danken at redhat.com
Mon Sep 1 21:15:40 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: Signs vdsm upgraded version for special treatment if required
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.ovirt.org/#/c/31561/7/vdsm.spec.in
File vdsm.spec.in:

Line 720: # When starting vdsm, init script will peform reconfigure automatically
Line 721: if [ "$1" -ge 1 ]; then
Line 722:     if [ "$(rpm -q vdsm 2> /dev/null | sed 's/^vdsm-4\.10\..*/OK/')" = "OK" ];
Line 723:     then
Line 724:         touch %{_localstatedir}/lib/%{vdsm_name}/requires_configure
> not sure why assuming anything and have exceptional statements for multiple
Alon, I don't understand your ellipsis.

Quoting all macros is the noble thing to do. But it has to happen throught the spec file, and clutter it badly.
Line 725:     fi
Line 726: fi
Line 727: 
Line 728: %post


-- 
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list