Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required

ybronhei at redhat.com ybronhei at redhat.com
Mon Sep 1 23:32:21 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: Signs vdsm upgraded version for special treatment if required
......................................................................


Patch Set 12:

(1 comment)

please ack if acceptable and I'll verify again

http://gerrit.ovirt.org/#/c/31561/12/init/vdsmd_init_common.sh.in
File init/vdsmd_init_common.sh.in:

Line 204:         local ret=0
Line 205:         if grep -q '^vdsm-4\.10\.' "${upgraded_ver_file}"; then
Line 206:              # We need to treat the upgrade from 4.10.x specifically
Line 207:              # by running manual configure command
Line 208:              "$VDSM_TOOL" configure --force
mooli: doing that will lead to libvirt service restart. but doing that in spec will do it during the installation, which make it much less user friendly. as the user can't expect libvirt service restart while upgrading vdsm. although you right about the unexpected behavior and we do print to stdout that we configure the service, so the user can understand from where the long start duration comes from..
Line 209:              ret=$?
Line 210:         fi
Line 211:         [ "${ret}" -eq 0 ] && rm -f "${upgraded_ver_file}"
Line 212:     fi


-- 
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list