Change in vdsm[master]: getVMFullList fails when processing externally managed vms

danken at redhat.com danken at redhat.com
Mon Sep 1 21:09:21 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: getVMFullList fails when processing externally managed vms
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/32263/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-09-01 17:47:33 +0200
Line 4: Commit:     pkliczewski <piotr.kliczewski at gmail.com>
Line 5: CommitDate: 2014-09-01 17:47:41 +0200
Line 6: 
Line 7: getVMFullList fails when processing externally managed vms
What are "externally managed vms" and why are they related to the bug? Wouldn't it occur with any big chunk of data?

Which m2crypto (please use full spelling, so everyone understand) function swallow errors? Which error? Did you open a m2crypto bug on that?
Line 8: 
Line 9: When we send 22k response we get -1 during send. After the investigation
Line 10: we found that m2c ignores error codes and returns -1. When we get -1 we
Line 11: need to get back to poll loop and retry which fixes the issue.


-- 
To view, visit http://gerrit.ovirt.org/32263
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia728691880771388b6179e85a97df3f303aeddf8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list