Change in vdsm[master]: vm: log xml from/to libvirt at 'info' level

fromani at redhat.com fromani at redhat.com
Wed Oct 22 11:53:13 UTC 2014


Francesco Romani has uploaded a new change for review.

Change subject: vm: log xml from/to libvirt at 'info' level
......................................................................

vm: log xml from/to libvirt at 'info' level

The XML which VDSM sends or receive to libvirt
is a critical piece of information for troubleshooting
issues, and we must make sure to log it unless the user
really want VDSM to be really silent.

So, bump the relevant logs from 'debug' to 'info'.

Change-Id: Ia07823512a8cdf5f05789b29bf3d4daa1a8ccb07
Signed-off-by: Francesco Romani <fromani at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/58/34358/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 3c9d138..0e22df7 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -2843,7 +2843,7 @@
 
         if not self.recovering and initDomain:
             domxml = hooks.before_vm_start(self._buildDomainXML(), self.conf)
-            self.log.debug(domxml)
+            self.log.info(domxml)
 
         if self.recovering:
             self._dom = NotifyingVirDomain(
@@ -2959,7 +2959,7 @@
         nicXml = hooks.before_nic_hotplug(nicXml, self.conf,
                                           params=nic.custom)
         nic._deviceXML = nicXml
-        self.log.debug("Hotplug NIC xml: %s", nicXml)
+        self.log.info("Hotplug NIC xml: %s", nicXml)
 
         try:
             self._dom.attachDevice(nicXml)
@@ -3188,7 +3188,7 @@
             nicXml = nic.getXML().toprettyxml(encoding='utf-8')
             hooks.before_nic_hotunplug(nicXml, self.conf,
                                        params=nic.custom)
-            self.log.debug("Hotunplug NIC xml: %s", nicXml)
+            self.log.info("Hotunplug NIC xml: %s", nicXml)
         else:
             self.log.error("Hotunplug NIC failed - NIC not found: %s",
                            nicParams)
@@ -3451,8 +3451,8 @@
 
             # Make sure the cached XML representation is valid as well
             xml = found_device.getXML().toprettyxml(encoding='utf-8')
-            self.log.debug("New device XML for %s: %s",
-                           found_device.name, xml)
+            self.log.info("New device XML for %s: %s",
+                          found_device.name, xml)
             found_device._deviceXML = xml
 
         return {'status': doneCode}
@@ -3509,7 +3509,7 @@
             return errCode['noimpl']
 
         driveXml = drive.getXML().toprettyxml(encoding='utf-8')
-        self.log.debug("Hotplug disk xml: %s" % (driveXml))
+        self.log.info("Hotplug disk xml: %s" % (driveXml))
 
         driveXml = hooks.before_disk_hotplug(driveXml, self.conf,
                                              params=drive.custom)
@@ -3561,7 +3561,7 @@
             return errCode['noimpl']
 
         driveXml = drive.getXML().toprettyxml(encoding='utf-8')
-        self.log.debug("Hotunplug disk xml: %s", driveXml)
+        self.log.info("Hotunplug disk xml: %s", driveXml)
 
         self._devices[DISK_DEVICES].remove(drive)
         # Find and remove disk device from vm's conf
@@ -3962,7 +3962,7 @@
             snapFlags |= libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE
 
         snapxml = snap.toprettyxml()
-        self.log.debug(snapxml)
+        self.log.info(snapxml)
 
         # We need to stop the collection of the stats for two reasons, one
         # is to prevent spurious libvirt errors about missing drive paths


-- 
To view, visit http://gerrit.ovirt.org/34358
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia07823512a8cdf5f05789b29bf3d4daa1a8ccb07
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>


More information about the vdsm-patches mailing list